Closed
Bug 1507981
Opened 6 years ago
Closed 6 years ago
Content Blocking UI Fallback
Categories
(Firefox :: Protections UI, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 65
People
(Reporter: tanvi, Assigned: ewright)
References
(Blocks 1 open bug)
Details
(Whiteboard: [privacy65][triage])
Attachments
(2 files)
We should have a fallback for the Content Blocking Standard setting, if we do not include blocking known tracking cookies in that category.
Proposal:
Create a pref to change the definition of Content Blocking Standard to just Tracking Protection in Private Mode.
We need to make a couple of changes based on that pref:
1) A new string in Preferences. Right now the string in the mocks is:
Balanced for protection and performance. Allows some trackers so websites function properly.
We need a new string for this (needinfo Betsy).
2) Under that string, we show 2 sections - "Known trackers only in Private Windows" and "Third-party tracking cookies". We should only show "Known trackers only in Private Windows".
Is there anything I'm missing? I don't think we need to make any changes to Control Center or the subpanels.
Reporter | ||
Comment 1•6 years ago
|
||
Note, that *if* we decide to make the Content Blocking Strict definition be 'Block all third party cookies AND Tracking Protection', we may also want to make the fallback pref to change the Strict definition to 'Block all third party tracking cookies using the Disconnect strict list AND Tracking Protection'. I'll needinfo myself to keep track of this, once the decision is made.
And needinfo'ing betsy for the string change mentioned in comment 0.
Flags: needinfo?(tanvi)
Flags: needinfo?(bmikel)
Comment 3•6 years ago
|
||
Some cases to think through when thinking about the fallback UI (there are probably more, I only spent a bit of time thinking about this so far...)
* How should the control centre look like with cookieBehavior==0. It is probably obvious/easy to figure out but let's make sure we have everything needed since that would be the default configuration with the fallback.
* If a user uses the Custom mode in prefs to turn on cookieBehavior==4, and then in the next release we update the definition of Standard to include cookieBehavior==4, what should happen to that user? Should they remain in Custom or be migrated back to Standard?
Comment 4•6 years ago
|
||
(In reply to Tanvi Vyas out until 11-26-18[:tanvi] from comment #2)
> Also needinfo pdol for sign off.
I agree with the approach that Tanvi outlined.
Flags: needinfo?(pdolanjski)
Comment 5•6 years ago
|
||
(In reply to :Ehsan Akhgari from comment #3)
> * If a user uses the Custom mode in prefs to turn on cookieBehavior==4,
> and then in the next release we update the definition of Standard to include
> cookieBehavior==4, what should happen to that user? Should they remain in
> Custom or be migrated back to Standard?
If it is easiest, let's just leave them in Custom since it's likely less confusing then switching them out of Custom and it's unlikely that they will change this setting regularly.
Comment 6•6 years ago
|
||
Fallback option for Standard is displayed in the UI here: https://mozilla.invisionapp.com/share/RHORBWDNX4W#/screens/327316993
String reads:
**Standard**
Only blocks known trackers in Private Windows.
There is no bulleted list below.
Flags: needinfo?(bmikel)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ewright
Assignee | ||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•6 years ago
|
||
If blocking third-party tracking cookies does not get turned on by default, this will be the UI we will use instead. The standard category only includes tracking protection in private windows, the standard section no longer expands.
Assignee | ||
Comment 8•6 years ago
|
||
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d481d6d9821
Land string early, awaiting decision on the rest of the patch. r=flod
Comment 10•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 11•6 years ago
|
||
Reopen to track the actual fallback UI, not just the early string landing. You can use the "leave-open" flag for this in the future :)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•6 years ago
|
I'd like to track this for 65.
tracking-firefox65:
--- → +
Comment 13•6 years ago
|
||
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d56cf7c8212a
Content Blocking UI Fallback. r=johannh
Comment 14•6 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 15•6 years ago
|
||
Johann to add steps on how to test this.
Flags: needinfo?(jhofmann)
Comment 16•6 years ago
|
||
- Open the browser toolbox: https://developer.mozilla.org/en-US/docs/Tools/Browser_Toolbox
- Insert this code in the console and press enter:
Services.prefs.getDefaultBranch("").setIntPref("network.cookie.cookieBehavior", 0)
- Open about:preferences
- You should see the fallback UI
- To get back to the original state you need to enter:
Services.prefs.getDefaultBranch("").setIntPref("network.cookie.cookieBehavior", 4)
Let me know if you have any more questions!
Thanks!
Flags: needinfo?(jhofmann)
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(tanvi)
Updated•6 years ago
|
Flags: qe-verify+
Comment 17•6 years ago
|
||
This bug is verified as fixed using the STR from comment 16, on 65.0b9 (20190107180200) across OSes: Win 10 x64, macOS 10.13 and Ubuntu 16.04 x64.
You need to log in
before you can comment on or make changes to this bug.
Description
•