Closed
Bug 1508127
Opened 6 years ago
Closed 4 years ago
CSS demo flickers during transition when scrolled
Categories
(Core :: DOM: Animation, defect, P3)
Core
DOM: Animation
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: mayankleoboy1, Unassigned)
References
()
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0
Steps to reproduce:
Create new profile (WR/non-WR)
go to https://alvarotrigo.com/pagePiling/examples/horizontalScroll.html#page2
scroll
Actual results:
the slide flickers when the transition ends
happens with or without WR
Expected results:
not so
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 1•6 years ago
|
||
2018-11-18T17:26:03: DEBUG : Starting merge handling...
2018-11-18T17:26:03: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=201a77bfe3bcb4865627103273a532f0a6db955c&full=1
2018-11-18T17:26:05: DEBUG : Found commit message:
Bug 1320608 - Make sure we wait for the next frame in the case where the animation started at the current frame. r=birtles
MozReview-Commit-ID: 2j2yEzPHUJI
2018-11-18T17:26:05: DEBUG : Did not find a branch, checking all integration branches
2018-11-18T17:26:05: INFO : The bisection is done.
2018-11-18T17:26:05: INFO : Stopped
Blocks: 1320608
Flags: needinfo?(hikezoe)
Updated•6 years ago
|
Component: General → DOM: Animation
Updated•6 years ago
|
Comment 2•6 years ago
|
||
I can see InitialOverflowProperty assertions [1] in OverflowChangedTracker when the slide transition happens. I don't know what happens there.
[1] https://hg.mozilla.org/mozilla-central/file/7e9cac76980a/layout/base/OverflowChangedTracker.h#l116
Comment 3•6 years ago
|
||
OK, this is actually caused by calling EffectSet::GetEffectSet(nsIFrame*) for the primary frame instead of style frame. We've been using the primary frame in various call sites of GetEffectSet.
Flags: needinfo?(hikezoe)
Comment 4•6 years ago
|
||
FWIW, (actually I don't think it's worth), here is a patch to use the style frame in EffectSet::GetEffectSet() and FindAnimationsForCompositor().
I've confirmed that this patch actually fixes the flicker, but we should instead audit all call sites of these functions and pass the style frame in the functions.
Updated•6 years ago
|
Priority: -- → P3
Reporter | ||
Comment 5•4 years ago
|
||
cant repro anymore
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•