One pattern of failures I see is when using function-like macros that do no use uppercase names or trailing semi-colons. Examples: https://github.com/sylvestre/gecko-dev/blob/master/mfbt/RecordReplay.h#L399 https://github.com/sylvestre/gecko-dev/blob/master/js/src/frontend/ParseNode.h#L526 I have a few patches which simply change casing to significantly improve the clang-format result without needing to |clang-format off|.

This pleases clang-format and makes many of these behave better when auto formatted. Special cases may still be marked |clang-format off| in later commits.

Depends on D12231

Use uppercase names for MOZ_MAKERECORDREPLAYWRAPPER* so that clang-format doesn't get confused and think these are return value types of functions. Depends on D12232

This makes clang-format stop mangling the macros. Depends on D12233

Depends on D12234

These changes should only change casing and all other naming and formatting is untouched. Try in progress: https://treeherder.mozilla.org/#/jobs?repo=try&revision=70accb1a4b0e104551319f5c79539a9bdde22721

Updated js/ patch to fix various python scripts that were using regex to find |macro|. New try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=882ecb7ff7b13ba6d1f9c67f26f7a458218b59bd

Landing part 1 immediately to avoid it rotting.

Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c8dd8f4166c9 Use uppercase names for high-order macros in js/ r=jandem

Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b020ea6c58e5 Use uppercase names for high-order macros in dom/ r=mccr8 https://hg.mozilla.org/integration/autoland/rev/b4ac72eabda0 Use uppercase macro names in mfbt/RecordReplay.h r=bhackett https://hg.mozilla.org/integration/autoland/rev/ffed3e597810 Use uppercase high-order macro names in xptinfo. r=nika https://hg.mozilla.org/integration/autoland/rev/0c683a3e80d8 Use uppercase high-order macro names in profiler. r=mstange

https://hg.mozilla.org/mozilla-central/rev/c8dd8f4166c9 https://hg.mozilla.org/mozilla-central/rev/b020ea6c58e5 https://hg.mozilla.org/mozilla-central/rev/b4ac72eabda0 https://hg.mozilla.org/mozilla-central/rev/ffed3e597810 https://hg.mozilla.org/mozilla-central/rev/0c683a3e80d8

[ESR Uplift Approval Request] If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format. User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future. Fix Landed on Version: 65 Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): This just changes the case of the names used in a C++ macro, virtually risk free. String or UUID changes made by this patch: None

Please see comment 12.

Please see comment 12.

Comment on attachment 9030989 [details] [diff] [review] ESR patch (part 1) OK for uplift to ESR60 as part of the clang-format project.

https://hg.mozilla.org/releases/mozilla-esr60/rev/1771e117ecae https://hg.mozilla.org/releases/mozilla-esr60/rev/ceb0a1655f01 https://hg.mozilla.org/releases/mozilla-esr60/rev/92d2ea3e3faa