Closed
Bug 1508217
Opened 6 years ago
Closed 6 years ago
remove broadcasters from mail/base
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1489447 +++
Remove <broadcaster> from mail/base
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9026004 -
Flags: review?(jorgk)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9026004 [details] [diff] [review]
bug1508217_de_broadcaster_otherActionsOpenIn.patch
Please rebase. A try run together with bug 1508209 would be great.
"try: -b do -p macosx64,linux64 -u all" should be sufficient.
Attachment #9026004 -
Flags: review?(jorgk)
|
|
Assignee | |
Comment 3•6 years ago
|
||
I don't think a rebase is needed.
Running on try now: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=23b75edc2e83b2a0dc933ed935e5cb23261de776
|
|
||
Comment 4•6 years ago
|
||
Just |hg pull -u| and you'll notice it ;-) - Plus you have two test failures, I'm not sure which of the three patches caused them:
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/message-header/test-header-toolbar.js | test-header-toolbar.js::test_customize_header_toolbar_dialog_style
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/message-header/test-header-toolbar.js | test-header-toolbar.js::test_customize_header_toolbar_change_button_style
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
|
Assignee | |
Comment 6•6 years ago
|
||
Should turn green - https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c8693bbe868b6ab639b4a2caad9438dc56bcb7ec
Attachment #9026004 -
Attachment is obsolete: true
Attachment #9026363 -
Flags: review?(jorgk)
|
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9026363 [details] [diff] [review]
bug1508217_de_broadcaster_otherActionsOpenIn.patch
Looks OK to me (I started with and easy one).
Attachment #9026363 -
Flags: review?(jorgk) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/72a2e97895e9
remove broadcasters from mail/base. r=jorgk
|
|
||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 65.0
|
||
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•