Closed
Bug 1508283
Opened 6 years ago
Closed 6 years ago
Don't attempt to check for updates from Firefox's nsBrowserGlue.js when running tests
Categories
(Testing :: geckodriver, defect)
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
Attachments
(1 file)
(deleted),
patch
|
jgraham
:
review+
|
Details | Diff | Splinter Review |
Spinoff of bug 1506917
Filing a separate bug due to the following comment in prefs.rs
// so please be careful and get review from a Testing :: geckodriver peer
I noticed that when running tests that nsBrowserGlue.js was attempting to check for an update. This can be disabled by setting the app.update.checkInstallTime bool pref to false.
The following change would cover it.
diff --git a/testing/geckodriver/src/prefs.rs b/testing/geckodriver/src/prefs.rs
--- a/testing/geckodriver/src/prefs.rs
+++ b/testing/geckodriver/src/prefs.rs
@@ -7,16 +7,19 @@ use mozprofile::preferences::Pref;
// so please be careful and get review from a Testing :: geckodriver peer
// before you make any changes to this file.
lazy_static! {
pub static ref DEFAULT: Vec<(&'static str, Pref)> = vec![
// Make sure Shield doesn't hit the network.
("app.normandy.api_url", Pref::new("")),
+ // Disable Firefox old build background check
+ ("app.update.checkInstallTime", Pref::new(false)),
+
// Disable automatically upgrading Firefox
("app.update.disabledForTesting", Pref::new(true)),
// Enable the dump function, which sends messages to the system
// console
("browser.dom.window.dump.enabled", Pref::new(true)),
// Disable safebrowsing components
Comment 1•6 years ago
|
||
AFAICT this is a pure addition and the pref has been unchanged since 2013, so r+ in principle on this change.
Assignee | ||
Comment 2•6 years ago
|
||
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #9026181 -
Flags: review?(james)
Updated•6 years ago
|
Attachment #9026181 -
Flags: review?(james) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/295cd66cea8f
Don't attempt to check for updates from Firefox's nsBrowserGlue.js when running tests. r=jgraham
Comment 4•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•