Closed
Bug 1508285
Opened 6 years ago
Closed 6 years ago
RootFront.listTabs and getTab should return BrowsingContextTargetFront rather than JSON forms
Categories
(DevTools :: Framework, enhancement, P2)
DevTools
Framework
Tracking
(Fission Milestone:M4, firefox66 fixed)
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
(Whiteboard: dt-fission)
Attachments
(3 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
Bug 1508285 - Refactor RootFront.listTabs to return BrowsingContextTargetFront instead of JSON form.
(deleted),
text/x-phabricator-request
|
Details |
Today, BrowsingContextTargetFront are instantiated late, in Target.attach when calling attachTarget:
https://searchfox.org/mozilla-central/rev/5117a4c4e29fcf80a627fecf899a62f117368abf/devtools/client/framework/target.js#532
const [, targetFront] = await this._client.attachTarget(this.form.actor);
https://searchfox.org/mozilla-central/rev/5117a4c4e29fcf80a627fecf899a62f117368abf/devtools/shared/client/debugger-client.js#375
front = new BrowsingContextTargetFront(this, { actor: targetActor });
But we should rather let protocol.js auto-marshalling instantiate all the fronts, when calling RootFront.listTabs and RootFront.getTab and than pass the fronts as an argument of Target class.
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: 6TOInM5BmYe
Assignee | ||
Comment 2•6 years ago
|
||
MozReview-Commit-ID: Ed5SyZbB0kq
Depends on D14173
Assignee | ||
Comment 3•6 years ago
|
||
MozReview-Commit-ID: 4CMHJ3tV7Rc
Depends on D14174
Assignee | ||
Comment 4•6 years ago
|
||
Almost green try:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=217393677&revision=7448b47b5dd8e4bef61005514d5699b159060b10
I pushed a fix for the eslint failure.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/433551bcded4
Refactor RootFront.getTab to return BrowsingContextTargetFront instead of JSON form. r=yulia
https://hg.mozilla.org/integration/autoland/rev/c4b0f1c1f723
Use RootFront.rootForm instead of listTabs to fetch global actors. r=yulia
https://hg.mozilla.org/integration/autoland/rev/651250445f44
Refactor RootFront.listTabs to return BrowsingContextTargetFront instead of JSON form. r=yulia,jdescottes
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/433551bcded4
https://hg.mozilla.org/mozilla-central/rev/c4b0f1c1f723
https://hg.mozilla.org/mozilla-central/rev/651250445f44
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Comment 7•5 years ago
|
||
Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.
This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:
0ee3c76a-bc79-4eb2-8d12-05dc0b68e732
Fission Milestone: --- → M4
You need to log in
before you can comment on or make changes to this bug.
Description
•