Enable ESLint for docshell
Categories
(Core :: DOM: Navigation, enhancement, P3)
Tracking
()
People
(Reporter: standard8, Assigned: pong7219, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [seneca-eslint][lang=js])
Attachments
(2 files, 2 obsolete files)
As part of rolling out ESLint across the tree, we should enable it for the rest of docshell, i.e. all of: docshell/test/browser/** docshell/test/iframesandbox/** docshell/test/mochitest/**
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Updated•6 years ago
|
Reporter | ||
Comment 3•6 years ago
|
||
I've not heard from Sathia, so opening this out as a mentored bug.
To help Mozilla out with this bug, here's the steps:
- Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
- Download and build the Firefox source code: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
- If you have any problems, please ask on IRC (https://wiki.mozilla.org/Irc) in the #introduction channel. They're there to help you get started.
- You can also read the Developer Guide, which has answers to most development questions: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Introduction
- Start working on this bug
- Please note:
- We want to end up with two separate commits. One with the automatic changes, the second with the manual changes.
- Although you'll change .eslintignore at the start, only the second commit should have the .eslintignore changes. Please follow the suggested commands.
- Here's what to do:
- In .eslintignore, remove the three
docshell/test/...
lines. - Run eslint
./mach eslint --fix docshell/test
- This should fix some of the issues.
- Inspect the diff to make sure that the indentation of the lines surrounding the changes look ok.
- Create a commit of the work so far. Note the extra
docshell
at the end (this avoids committing .eslintignore at this stage)$ hg commit -m "Bug nnn - Enable ESLint for docshell (automatic changes). r?Standard8" docshell
- For the remaining issues, you'll need to fix them by hand. To find them, run
./mach eslint docshell
.- Most of those should be reasonably easy to understand, but there's more information on some specific bits (especially no-undef) here:
- Create a second commit of the manual changes, note, there's no directory specifier this time, so .eslintignore will be included.
$ hg commit -m "Bug nnn - Enable ESLint for docshell (manual changes). r?Standard8
- Post the two commits via phabricator. Please use moz-phab to submit them.
- In .eslintignore, remove the three
- Please note:
- Once the patches are submitted, I'll take a look. If there's any changes necessary I'll comment in Phabricator, so be prepared to update the patches. If there's no changes, I'll request review from a docshell peer, so there may still be more to go.
- Once we're happy with the changes, I'll push it to autoland - our integration branch. Your code will then soon be shipping to Firefox users worldwide!
- Now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
Assignee | ||
Comment 4•6 years ago
|
||
Hi Mark,
I could work on this, if that's ok :)
Thanks!
Reporter | ||
Comment 5•6 years ago
|
||
Hi Mellina, I've assigned it to you, please start working on it. Feel free to ask questions.
Assignee | ||
Comment 6•6 years ago
|
||
Hi Mark,
Thanks! I will work on it today and will have updates tomorrow.
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
Depends on D23037
Assignee | ||
Updated•6 years ago
|
Reporter | ||
Comment 9•6 years ago
|
||
Hi Mellina, sorry I haven't gotten to look at this yet - I've had lots on the last day or so. I hope to look at it tomorrow if not before.
Assignee | ||
Comment 10•6 years ago
|
||
Hi Mark, don't worry! There is a lot to check here as well, I understand.
I just gave a heads-up in case you haven't seen it.
Please take your time.
Reporter | ||
Comment 11•6 years ago
|
||
Boris, can you accept the automatic changes as well please?
![]() |
||
Comment 12•6 years ago
|
||
Sorry, I had missed there were two requests, somehow. Done.
Assignee | ||
Comment 13•6 years ago
|
||
Updated•6 years ago
|
Comment 14•6 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b338bce4319e Enable ESLint for docshell (automatic changes). r=Standard8,bzbarsky https://hg.mozilla.org/integration/autoland/rev/cb0dd2254bc3 Enable ESLint for docshell (manual changes). r=Standard8,bzbarsky
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b338bce4319e
https://hg.mozilla.org/mozilla-central/rev/cb0dd2254bc3
Updated•5 years ago
|
Description
•