Closed Bug 1508823 Opened 6 years ago Closed 6 years ago

Enable ESLint for dom/browser-element

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [seneca-eslint])

Attachments

(2 files)

Bug 1508823 - Enable ESLint for dom/browser-element (manual changes). r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1508823 - Enable ESLint for dom/browser-element (automatic changes). r?ehsan
(deleted), text/x-phabricator-request
Details
As part of rolling out ESLint across the tree, we should enable it for dom/browser-element
Hi, I'd like to tackle this bug.
Assignee: standard8 → jsbhamber2
Hi Jagmeet, thank you for the patch, but it seems this is only the manual changes commit, and the automatic changes commit is missing. Did you use `moz-phab submit` with no additional arguments? In theory that should upload correctly.
Flags: needinfo?(jsbhamber2)
No, I included another argument containing the commit number. I saw a classmate do this who included 2 commits. I used `hg summary` to list my commits but only saw the ID for the manual-changes commit. What should I do to upload my automatic changes as well?
Flags: needinfo?(jsbhamber2)
I believe `hg summary` will only list the top commit. If you use just `moz-phab submit` with no additional arguments then it should automatically work out which commits to post - it will prompt you before hand as well

I've not heard from Jagmeet, so stealing this to see what we can get landed here.

Assignee: jsbhamber2 → standard8
Attachment #9030385 - Attachment description: Bug 1508823 - Enable ESLint for dom/browser-element/ → Bug 1508823 - Enable ESLint for dom/browser-element (manual changes). r?ehsan
Component: DOM → DOM: Core & HTML
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21cd0b75c1c3 Enable ESLint for dom/browser-element (automatic changes). r=Ehsan https://hg.mozilla.org/integration/autoland/rev/a52b7d427119 Enable ESLint for dom/browser-element (manual changes). r=mccr8

https://hg.mozilla.org/mozilla-central/rev/21cd0b75c1c3
https://hg.mozilla.org/mozilla-central/rev/a52b7d427119

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: