Closed
Bug 1508826
Opened 6 years ago
Closed 6 years ago
Add mach_override.c and mach_override.h to ThirdPartyPaths
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla65
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
patch
|
lizzard
:
approval-mozilla-esr60+
|
Details | Diff | Splinter Review |
These two files are imported. See bug 1508773 for files that should be updated.
|
Assignee | |
Comment 1•6 years ago
|
||
Also, xpcom/io/crc32c.c, though that's kind of an excerpt.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4a6bd0a9e00
Add mach_override.* and crc32c.c to ThirdPartyPaths.txt. r=Ehsan
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
||
Comment 5•6 years ago
|
||
[ESR Uplift Approval Request]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.
User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.
Fix Landed on Version: 65
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): This is NPOTB.
String or UUID changes made by this patch: None
Attachment #9031010 -
Flags: approval-mozilla-esr60?
status-firefox-esr60:
--- → affected
Comment on attachment 9031010 [details] [diff] [review]
ESR patch
OK for uplift to ESR for clang-format project.
Attachment #9031010 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Attachment #9031024 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
|
|
||
Comment 8•6 years ago
|
||
| bugherder uplift | ||
|
|
||
Updated•6 years ago
|
Attachment #9031010 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•