There are a few things in the Linux sandbox code where the upcoming reformat (bug 1188202) will mess up some intentional vertical alignment. The enums I'm not too bothered by, but the socketcall/ipc table in SandboxFilterUtil.cpp is, I think, worth keeping in its current tabular form. I have a patch….

The tables in SandboxFilterUtil.cpp should remain vertically aligned, but clang-format would disagree. This patch excludes that region from reformatting, and applies the other changes that clang-format would make there.

Pushed by jedavis@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/023c546c01cd Prepare the Linux sandbox's socketcall/ipc-call dispatch table for reformatting. r=gcp

Comment on attachment 9026592 [details] Bug 1508898 - Prepare the Linux sandbox's socketcall/ipc-call dispatch table for reformatting. [ESR Uplift Approval Request] If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format. User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future. Fix Landed on Version: 65 Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): This is whitespace change. String or UUID changes made by this patch: None

Comment on attachment 9026592 [details] Bug 1508898 - Prepare the Linux sandbox's socketcall/ipc-call dispatch table for reformatting. OK for uplift to ESR60 as part of the clang-format project.