Closed
Bug 1508989
Opened 6 years ago
Closed 6 years ago
Enable ESLint for dom/filesystem
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: standard8, Assigned: aspucciano)
References
Details
(Whiteboard: [seneca-eslint])
Attachments
(2 files, 5 obsolete files)
As part of rolling out ESLint across the tree, we should enable it for dom/filesystem.
Priority: -- → P3
Reporter | ||
Updated•6 years ago
|
Assignee: standard8 → aspucciano
Updated•6 years ago
|
Attachment #9027747 -
Attachment description: Bug 1508989 - Enable ESLint for {dom/filesystem}/ (manual changes) nit fix → Bug 1508989 - Enable ESLint for {dom/filesystem}/ (manual changes)
Updated•6 years ago
|
Attachment #9027693 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9027695 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9027747 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9028525 -
Attachment is obsolete: true
Reporter | ||
Comment 8•6 years ago
|
||
Adam, these are looking good and ready to land, but there's one issue - the author field for the commits isn't quite right. It should be of format "Name <email>" (e.g. see https://hg.mozilla.org/mozilla-central/rev/77f0c6b51d00).
At the moment, I think your authors are down as "aspucciano".
Please can you try updating the commits? I think you should be able to use `hg histedit` to edit the individual commits, and to change the author/user via:
$ hg commit --amend --user "Name <email">
Please do that for both commits, then use `moz-phab submit` to upload them again.
Flags: needinfo?(aspucciano)
Reporter | ||
Comment 9•6 years ago
|
||
Note: if the author information is correct anyway, please can you try rebasing and then use `moz-phab submit` to submit both patches again.
Assignee | ||
Comment 10•6 years ago
|
||
Comment 11•6 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3930f1e2fc9e
Enable ESLint for dom/filesystem / (automatic changes) r=Standard8
https://hg.mozilla.org/integration/autoland/rev/bd4e540b0801
Enable ESLint for dom/filesystem / (manual changes) r=Standard8
Reporter | ||
Comment 12•6 years ago
|
||
Hi Adam, thanks for the update. It didn't quite go right, but I've managed to work around that, so this has now landed on our integration branches.
If all goes well, it should be merged to the main branch within the next 24 hours or so.
Thank you for all your work on this and sticking with it.
Flags: needinfo?(aspucciano)
Updated•6 years ago
|
Attachment #9029176 -
Attachment is obsolete: true
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3930f1e2fc9e
https://hg.mozilla.org/mozilla-central/rev/bd4e540b0801
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Reporter | ||
Comment 14•6 years ago
|
||
This is all landed now and incorporated into the main code. Well done Adam, thank you for all the work.
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•