Closed Bug 1508990 Opened 6 years ago Closed 6 years ago

Enable ESLint for dom/ipc

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: standard8, Assigned: adam.kolodko)

References

Details

(Whiteboard: [seneca-eslint])

Attachments

(2 files)

Bug 1508990 - Enable ESLint for dom/ipc/ (automatic changes)
(deleted), text/x-phabricator-request
Details
Bug 1508990 - Enable ESLint for dom/ipc/ (manual changes)
(deleted), text/x-phabricator-request
Details
As part of rolling out ESLint across the tree, we should enable it for dom/ipc.
I am interested in taking care of this issue.
Assignee: standard8 → adam.kolodko
Adam, the automatic changes look good. Are you planning on posting the manual changes as well? If not, could you drop the .eslintignore change and re-submit? We can then land the automatic changes, and handle the manual ones separately.
Flags: needinfo?(adam.kolodko)
I am working on the manual changes as well, I'm working on one bug that should be resolved in a day or so.
Flags: needinfo?(adam.kolodko)
Ok, that's great. Thanks.
Depends on D13887
Pushed by btara@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/ee53b8193826 Enable ESLint for dom/ipc/ (automatic changes) r=Standard8,mrbkap https://hg.mozilla.org/mozilla-central/rev/3bb8efd6f02e Enable ESLint for dom/ipc/ (manual changes) r=Standard8,mrbkap
https://hg.mozilla.org/mozilla-central/rev/ee53b8193826 https://hg.mozilla.org/mozilla-central/rev/3bb8efd6f02e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Thank you for all the work on this Adam. This has now landed and is in our main branch.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: