Closed
Bug 1509048
Opened 6 years ago
Closed 6 years ago
[tryselect] Pass full taskgraph to selectors
Categories
(Developer Infrastructure :: Try, enhancement)
Developer Infrastructure
Try
Tracking
(firefox-esr60 fixed, firefox65 fixed)
RESOLVED
FIXED
mozilla65
People
(Reporter: ahal, Assigned: ahal)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Currently the selectors only have access to a list of labels. But if they could access the entire task definition, they would be able to accomplish a lot more.
I had previously implemented this as part of bug 1499822, but this will be useful for other purposes as well, and I'm not sure when that bug will be able to land. So spinning this change into a new bug to get it landed sooner.
Assignee | ||
Comment 1•6 years ago
|
||
Currently selectors that generate the taskgraph receive a list of task labels
back. While this works, it isn't very robust and limits the selectors in what
they can accomplish.
For example, it means we need to use regexes to map test suites to tasks. If
we had the full taskgraph, we could use filter functions instead.
There are also new selectors in the works which will need this (like ./mach
try chooser). Finally the try syntax selector would also need this if we
ever migrate it to use the 'try_task_config.json' format.
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/306f3bd4760a
[tryselect] Pass full taskgraph into selectors, r=marco
Comment 3•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment 4•6 years ago
|
||
bugherder uplift |
status-firefox-esr60:
--- → fixed
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•