Closed
Bug 1509212
Opened 6 years ago
Closed 6 years ago
Trackers button should get a grey background on hover, not a blue one
Categories
(Firefox :: Site Identity, defect, P1)
Firefox
Site Identity
Tracking
()
VERIFIED
FIXED
Firefox 65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | verified |
People
(Reporter: bruce.bugz, Assigned: bruce.bugz)
References
Details
(Whiteboard: [privacy65])
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
johannh
:
review+
|
Details | Diff | Splinter Review |
vs spec.PNG
I think `#identity-popup-content-blocking-category-tracking-protection` needs `-moz-appearance: none`
|
||
Comment 1•6 years ago
|
||
I would agree, off-hand. Do you want to make a patch?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(ampersand100000)
Priority: -- → P2
Whiteboard: [privacy65]
(In reply to Johann Hofmann [:johannh] from comment #1)
> I would agree, off-hand. Do you want to make a patch?
I have never submitted a patch before so it could take me a little while but I'd like to try, yes.
Flags: needinfo?(ampersand100000)
|
|
||
Comment 3•6 years ago
|
||
Awesome, please go for it.
You can read https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction for a guide on how to contribute, or feel free to ask me for help on IRC (https://wiki.mozilla.org/IRC) or here in Bugzilla.
Thanks!
Assignee: nobody → ampersand100000
Status: NEW → ASSIGNED
Priority: P2 → P1
This seems to fix the issue for me on Windows 10.
irc.mozilla.org appears to be down at the moment, hence requesting feedback here itself.
Thanks.
Attachment #9027241 -
Flags: review?(jhofmann)
|
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9027241 [details] [diff] [review]
bug1509212.patch
Review of attachment 9027241 [details] [diff] [review]:
-----------------------------------------------------------------
That looks great, thank you! I'll set the checkin-needed flag to get this landed.
Attachment #9027241 -
Flags: review?(jhofmann) → review+
|
|
||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e8d63408d5f
Don't use platform-native styling for the 'Trackers' button in the identity panel. r=johannh
Keywords: checkin-needed
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
|
||
Comment 8•6 years ago
|
||
Verified on Windows 10, Ubuntu 18, Mac OS, on Nightly 65.0a1 (2018-11-27).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•