Closed
Bug 1509327
Opened 6 years ago
Closed 6 years ago
Update dav1d upstream and use the new timing and color parameter.
Categories
(Core :: Audio/Video: Playback, enhancement, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: achronop, Assigned: achronop)
References
Details
Attachments
(3 files)
For better A/V synchronization the timing parameters, like timecode, duration and offset, need to be given by the decoder.
The same for colorspace values. Note, color semantics are described from the spec here:
https://aomediacodec.github.io/av1-spec/#color-config-semantics
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Additional comments to implement with that bug:
https://phabricator.services.mozilla.com/D12164#320547 <-- this might get in sooner if Bug 1510265 is about to get landed
https://phabricator.services.mozilla.com/D12164#320544
Assignee | ||
Comment 2•6 years ago
|
||
New pull from upstream to commit 06331de. Found one new warning [1] and one crash [2].
[1] https://code.videolan.org/videolan/dav1d/issues/196
[2] https://code.videolan.org/videolan/dav1d/issues/197
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Latest dav1d version supports to store the timing information in undecoded frame and restore it later from decoded picture. This can provide more accurate timing especially during drain. In additionto that, colorspace information is set according to the size of the image. Finally this patch addresses some style comments.
Updated•6 years ago
|
Attachment #9028670 -
Attachment description: Bug 1509327 - Update dav1d from upstream to be15be3. r?TD-Linux → Bug 1509327 - Update dav1d from upstream to 9e08ac7. r?TD-Linux
Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9881fd46fde2
Update dav1d from upstream to 9e08ac7. r=TD-Linux
https://hg.mozilla.org/integration/autoland/rev/ea27440a2126
Update libdav1d build file after import. r=TD-Linux
https://hg.mozilla.org/integration/autoland/rev/aeb00b8974a4
Use timing and color information from decoded picture in dav1d wrapper. r=jya
Comment 7•6 years ago
|
||
Backed out for build bustages
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=aeb00b8974a472794d513c5884c38a96397334da
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214754132&repo=autoland&lineNumber=9127
Backout: https://hg.mozilla.org/integration/autoland/rev/1b5ec7fefbbf8959db1bb438b6491d925074b066
Flags: needinfo?(achronop)
Updated•6 years ago
|
Attachment #9028670 -
Attachment description: Bug 1509327 - Update dav1d from upstream to 9e08ac7. r?TD-Linux → Bug 1509327 - Update dav1d from upstream to 36b807a. r?TD-Linux
Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2094783e3288
Update dav1d from upstream to 36b807a. r=TD-Linux
https://hg.mozilla.org/integration/autoland/rev/6facccbbd28c
Update libdav1d build file after import. r=TD-Linux
https://hg.mozilla.org/integration/autoland/rev/a2d943e9f9aa
Use timing and color information from decoded picture in dav1d wrapper. r=jya
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2094783e3288
https://hg.mozilla.org/mozilla-central/rev/6facccbbd28c
https://hg.mozilla.org/mozilla-central/rev/a2d943e9f9aa
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•