Closed Bug 150994 Opened 22 years ago Closed 22 years ago

iframe with tabindex shortens tab cycle

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

x86
Windows 2000
defect
Not set
major

Tracking

()

VERIFIED FIXED

People

(Reporter: jruderman, Assigned: yuanyi21)

References

(Blocks 1 open bug, )

Details

(Keywords: access)

Attachments

(2 files, 1 obsolete file)

The Hotmail "welcome" page has an iframe with a tabindex.  It's not possible to
get to any link beyond the iframe using the tab key.

Tab:
Links above iframe -> Iframe content area -> Iframe content.  (Skips links below
iframe, content area, location bar.)

Shift+Tab:
Links below iframe -> Iframe content -> Iframe content area -> Content area ->
Location bar.  (Skips links above iframe.)
Attached file testcase (deleted) —
Sorry bryner
Assignee: aaronl → bryner
Blocks: focusnav
Keywords: access
see: http://www.w3.org/TR/html401/interact/forms.html#adef-tabindex
only A, AREA, BUTTON, INPUT, OBJECT, SELECT, and TEXTAREA support tabindex
attribute. so we shouldn't get this for other elements.
Attachment #109627 - Flags: review?(aaronl)
Comment on attachment 109627 [details] [diff] [review]
don't get tabindex for element that don't support it

r=aaronl

Bryner, is this fix okay?
Attachment #109627 - Flags: superreview?(bryner)
Attachment #109627 - Flags: review?(aaronl)
Attachment #109627 - Flags: review+
Comment on attachment 109627 [details] [diff] [review]
don't get tabindex for element that don't support it

That may be true for HTML, but not for XUL.  Please do an IsContentOfType check
before checking the tag.
Attachment #109627 - Flags: superreview?(bryner) → superreview-
See also bug 171366, tabindex should work for anything focusable.
Attached patch patch addressed bryner comment (deleted) — Splinter Review
Attachment #109627 - Attachment is obsolete: true
Attachment #110640 - Flags: superreview?(bryner)
Attachment #110640 - Flags: review?(aaronl)
Comment on attachment 110640 [details] [diff] [review]
patch addressed bryner comment

r=aaronl
Attachment #110640 - Flags: review?(aaronl) → review+
Comment on attachment 110640 [details] [diff] [review]
patch addressed bryner comment

sr=bryner
Attachment #110640 - Flags: superreview?(bryner) → superreview+
taking...
Assignee: bryner → kyle.yuan
checked in!
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
vrfy'd fixed with 2003.01.13.08 comm trunk bits. tested with testcase on linxu
rh8.0, win2k and mac 10.2.3.
Status: RESOLVED → VERIFIED
Component: Keyboard: Navigation → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: