Open
Bug 1510032
Opened 6 years ago
Updated 2 years ago
Redundant modifiers in API interfaces
Categories
(GeckoView :: General, enhancement, P3)
GeckoView
General
Tracking
(firefox65 affected)
NEW
Tracking | Status | |
---|---|---|
firefox65 | --- | affected |
People
(Reporter: agi, Unassigned, Mentored)
References
(Blocks 1 open bug)
Details
Inside Java interfaces, all fields are |public static final| and all classes are |public static| and all interfaces are |public|. There are a lot of places where we manually specify (some of) these modifiers, which may be confusing as you may e.g. be induced to think that removing that modifier will make the field non-public or non-final.
There are actual example of this where we mark some fields as |/* package */| like they were package protected but really they are public e.g. [0].
I say we remove all of these redundant modifiers to avoid ambiguity.
[0]: https://searchfox.org/mozilla-central/rev/d35199ef15ffa57d190886e20d5df6471faf0870/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java#4279
Updated•6 years ago
|
Priority: -- → P3
Reporter | ||
Updated•6 years ago
|
Mentor: agi
Updated•6 years ago
|
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•