These are autogenerated files so we shouldn't try to reformat them.

These are autogenerated files so we shouldn't try to reformat them.

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f44e47ef7b3 Ignore files generated by protobuf in the tree r=sylvestre

What paths is this intended to catch? I don't see any matches in my tree. (This patch looks like a mix of regex and glob...)

(In reply to David Major [:dmajor] from comment #3) > What paths is this intended to catch? I don't see any matches in my tree. > (This patch looks like a mix of regex and glob...) Sorry I missed your question. This is intended to catch these files: <https://searchfox.org/mozilla-central/search?q=&case=false&regexp=false&path=.pb.%7Bcc%2Ch%7D>

Comment on attachment 9027804 [details] Bug 1510124 - Ignore files generated by protobuf in the tree [ESR Uplift Approval Request] If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format. User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future. Fix Landed on Version: 65 Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): This is NPOTB. String or UUID changes made by this patch: None

(In reply to :Ehsan Akhgari from comment #5) > (In reply to David Major [:dmajor] from comment #3) > > What paths is this intended to catch? I don't see any matches in my tree. > > (This patch looks like a mix of regex and glob...) > > Sorry I missed your question. This is intended to catch these files: > > <https://searchfox.org/mozilla-central/ > search?q=&case=false&regexp=false&path=.pb.%7Bcc%2Ch%7D> Do I understand correctly that the patch would also catch e.g. `foo_pb_h`? I'm still not quite clear on what exactly the wildcard format is here.

Comment on attachment 9027804 [details] Bug 1510124 - Ignore files generated by protobuf in the tree OK for uplift to ESR60 as part of the clang-format project.

(In reply to David Major [:dmajor] from comment #7) > (In reply to :Ehsan Akhgari from comment #5) > > (In reply to David Major [:dmajor] from comment #3) > > > What paths is this intended to catch? I don't see any matches in my tree. > > > (This patch looks like a mix of regex and glob...) > > > > Sorry I missed your question. This is intended to catch these files: > > > > <https://searchfox.org/mozilla-central/ > > search?q=&case=false&regexp=false&path=.pb.%7Bcc%2Ch%7D> > > Do I understand correctly that the patch would also catch e.g. `foo_pb_h`? > I'm still not quite clear on what exactly the wildcard format is here. It gets replaced with '**' and gets passed to --exclude as an argument to git diff, see: https://searchfox.org/mozilla-central/rev/fd32b3a6fa3eff1468311f6fcf32b45c117136df/python/mozbuild/mozbuild/mach_commands.py#2684 https://git-scm.com/docs/gitglossary#gitglossary-glob <quote> A leading "**" followed by a slash means match in all directories. For example, "**/foo" matches file or directory "foo" anywhere, the same as pattern "foo". "**/foo/bar" matches file or directory "bar" anywhere that is directly under directory "foo". </quote>