Closed
Bug 1510178
Opened 6 years ago
Closed 6 years ago
remove broadcasters from common/
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1489447 +++
Remove broadcasters from common/
Assignee | ||
Comment 1•6 years ago
|
||
History is a seamonkey thing - https://searchfox.org/comm-central/source/common/src/viewSource.xul#300 so we don't need to worry about navigation.
Their viewsource looks non salvageable, we probably should move this to mail and remove all the unneeded junk. But then again, I didn't know they removed the stand-alone view source in Firefox (bug 1418403).
This does it for now.
Attachment #9027847 -
Flags: review?(geoff)
Updated•6 years ago
|
Attachment #9027847 -
Flags: review?(geoff) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Comment 2•6 years ago
|
||
Comment on attachment 9027847 [details] [diff] [review]
bug1510178_debroadcaster_common.patch
Review of attachment 9027847 [details] [diff] [review]:
-----------------------------------------------------------------
::: common/src/viewSource.xul
@@ +141,5 @@
> accesskey="&forwardCmd.accesskey;"
> command="Browser:Forward"
> observes="viewSourceNavigation"/>
> <menuseparator observes="viewSourceNavigation"/>
> +#else
This looks wrong. Where is the #endif??
Updated•6 years ago
|
Keywords: checkin-needed
Comment 3•6 years ago
|
||
Yeesh, how did I miss that? Good thing somebody's awake.
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•6 years ago
|
Attachment #9028244 -
Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2a56bbf37048
remove broadcasters from common/. r=darktrojan
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 65.0
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•