Closed Bug 1510289 Opened 6 years ago Closed 6 years ago

Disable WebRender for the build before 65.0 RC

Categories

(Core :: Graphics: WebRender, defect, P2)

Product:
Core
Component:
Graphics: WebRender
Version:
Other Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox64 --- unaffected
firefox65 blocking verified
firefox66 --- unaffected

People

(Reporter: kats, Assigned: jrmuizel)

References

Details

(Whiteboard: [gfx-noted][land in late Beta])

Attachments

(1 file)

Don't let WR ride on 65
(deleted), patch
jrmuizel
: review+
jcristau
: approval-mozilla-release+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #1499088 +++ In bug 1498711 we turned on WebRender without #ifdef guards so that it can ride to late beta. However, until we're ready to let it ride to release, we'll need to turn it back off in beta for the last build before RC. Bug 1499088 did that for the 64 beta train, and this bug is tracking doing the same thing for the 65 beta train. This bug should block the 65 release so that we don't accidentally ship WebRender on 65 release.
Julien, do you know the approximate date the last pre-RC build will be built for 65?
Flags: needinfo?(jcristau)
I'm the 65 release owner, FWIW :). I was thinking we'd land this directly on m-r after the uplift before building the RC rather than pushing it to Beta. Does that work for you? If so, just attach the patch and get it reviewed and we'll go from there.
Flags: needinfo?(jcristau)
That sounds fine to me. I'll be away for a couple of weeks so I might not be around to actually land the patch but I'll put up and get it reviewed.
Attached patch Don't let WR ride on 65 (deleted) — — Splinter Review

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1490742

User impact if declined: WebRender will get turned on in release for the MVP audience when 65 release goes out the door

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: On a desktop windows 10 machine with NVidia graphics, ensure webrender is turned off by default (check in about:support)

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Pref flip. We did the same thing for 64 in bug 1499088

String changes made/needed: None

Attachment #9034836 - Flags: review?(jmuizelaar)
Attachment #9034836 - Flags: approval-mozilla-release?

Form ^ is for 65 release (not 64 release) since RyanVM said we'd land the patch directly on the 65 release branch before building the RCs.

Attachment #9034836 - Flags: review?(jmuizelaar) → review+
Assignee: kats → jmuizelaar
Comment on attachment 9034836 [details] [diff] [review] Don't let WR ride on 65 turn off WR for 65.0 rc1
Attachment #9034836 - Flags: approval-mozilla-release? → approval-mozilla-release+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Flags: qe-verify+

Confirming that gfx.webrender.all.qualified is set to false on 65.0-build1 (20190121133710) using a Windows 10 machine with Nvidia GeForce GT 620 gpu.

Status: RESOLVED → VERIFIED
status-firefox65: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: