ASR Snippets: Provide a way to preview snippets in other themes
Categories
(Firefox :: New Tab Page, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | verified |
People
(Reporter: giorgos, Assigned: andreio)
References
Details
(Keywords: github-merged)
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-github-pull-request
|
Details |
Reporter | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 9051334 [details]
Bug 1510335 - ASR Snippets: Provide a way to preview snippets in other themes
This is part of a devtool feature for Snippets that allows content creators to preview snippets + content in a newtab.
By whitelisting a host (browser.newtab.activity-stream.asrouter.whitelistHosts) we fetch snippet content from a URL passed in using query parameters.
The issue here is that LightweightThemeChild.jsm
is not whitelisted for about:newtab?endpoint=...
, LightweightTheme:Set
never fires and the newtab loaded will have the default light theme even if the browser has dark theme set.
Reporter | ||
Comment 4•6 years ago
|
||
Andrei could we get this to allow theme selection in the URL?
something like
about:newtab?endpoint=....&theme=light
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
(In reply to GitHub Bugzilla PR Linker from comment #5)
I made a PR implementing this, waiting on review to see if there are any concerns.
Reporter | ||
Comment 7•6 years ago
|
||
I see the PR is merged, w00t!
Which release version is planned to get this?
Also how do we use this? Is there supporting documentation?
ThankS!
Updated•6 years ago
|
Assignee | ||
Comment 8•6 years ago
|
||
This will be available in 68, it's not in Nightly yet (will be when this bug is closed). I'll add some documentation about it but it works as you described, no pref or config required.
about:newtab?endpoint=http://foo.com&theme=light // or "dark"
Updated•6 years ago
|
Comment 9•6 years ago
|
||
Comment 10•6 years ago
|
||
I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190407214820) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now the Snippets can be also previewed in other themes.
Updated•5 years ago
|
Description
•