Open Bug 1510384 Opened 6 years ago Updated 2 years ago

After entering fullscreen the size of video controls shouldn't vary depending on mobile/ desktop site

Categories

(Toolkit :: Video/Audio Controls, defect, P5)

65 Branch
ARM
Android
defect

Tracking

()

Tracking Status
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- affected

People

(Reporter: csheany, Unassigned)

Details

(Whiteboard: [geckoview:fenix:p3])

Attachments

(4 files)

User Agent: Mozilla/5.0 (Android 7.1.1; Tablet; rv:65.0) Gecko/65.0 Firefox/65.0

Steps to reproduce:

1. Open mozilla.org/en-us/firefox
2. Enter fullscreen of a video
3. Exit fullscreen
4. Request desktop site
5. Enter fullscreen of a video


Actual results:

The size of the controls are different


Expected results:

To be determined
Attached image Screenshot_20181127-134837.jpg (deleted) —
Attached image Screenshot_20181127-134921.jpg (deleted) —
Would be good to understand if this is a recent regression, and if so get a regression range.
Keywords: qawanted
Do you agree?

I understand why they are scaled differently on the page bug don't think it should translate to fullscreen?

Firefox 48 was major update and is affected. 

They were updated to match photon but I believe that was only visual.

To confirm the page should zoomed out given Bug 791192.

Mobile is problematic due to screen real estate.
(In reply to csheany from comment #4)
> Do you agree?

I agree that it's strange that the controls are different sizes when the video is the same size, yes.

I think having them be the larger size (as in the first screenshot) is preferable.

It's not clear me to what the cause of the difference in size is. This will require some investigation.

> Firefox 48 was major update and is affected. 

If the issue was present in Firefox 48, then at least we can rule out a recent regression from something like bug 1493976.
Thanks for the report!
I was able to reproduce this issue on the latest Nightly build with Nexus 5(Android 6.0.1) following the steps from the description. I will mark the bug as New and try to find a regression window.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Unspecified → Android
Hardware: Unspecified → ARM
Tested with builds till 2016-12-02 and the issue is reproducible following the steps provided. I don't think it's a recent regression, and the controls are smaller https://i.imgur.com/50cTcky.png.
Keywords: qawanted
Pre-48 controls have the same behavior however the design was different.
Attached image Screenshot_20181230-145234.jpg (deleted) —
Attached image Screenshot_20181230-145041.jpg (deleted) —
Is Bug 495593 related?
(In reply to csheany from comment #11)
> Is Bug 495593 related?

Not in the sense that it caused this bug, but a fix here may well involve changing the same part of the front-end code as the patch in that bug.

Also, the component of that bug (Toolkit :: Video/Audio Controls) is probably a better component for this bug.
Component: General → Video/Audio Controls
Product: Firefox for Android → Toolkit
Version: Firefox 65 → 65 Branch

Tim, would you mind taking a look?

Flags: needinfo?(timdream)

This is not a recent regression. Video controls always follow the viewport size. It might be strange considering in fullscreen mode there is no UI other than video controls so yeah I agree we should change the behavior.

(In reply to Sorina Florean [:sorina] from comment #7)

Tested with builds till 2016-12-02 and the issue is reproducible following
the steps provided. I don't think it's a recent regression, and the controls
are smaller https://i.imgur.com/50cTcky.png.

(In reply to csheany from comment #8)

Pre-48 controls have the same behavior however the design was different.

Flags: needinfo?(timdream)

Allow me to share more context

  • mobile video controls were changed in bug 1444489 to align with desktop.
  • to implement the feature here, you would want to change the dimensions of the video controls DOM to be independent of the viewport CSS pixel size. That probably means size everything in vmin/vmax or whatnot.

This would also benefit sites that aren't implicitly "desktop"

https://downloadfiletest-eab8a.firebaseapp.com/

Consider for Fenix

Flags: needinfo?(cpeterson)
Flags: needinfo?(cpeterson)
Whiteboard: [geckoview:fenix:p3]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: