Closed
Bug 1510410
Opened 6 years ago
Closed 6 years ago
[meta] Enable LSNG pref on Nightly
Categories
(Core :: Storage: localStorage & sessionStorage, enhancement, P3)
Core
Storage: localStorage & sessionStorage
Tracking
()
RESOLVED
FIXED
mozilla66
People
(Reporter: janv, Assigned: janv)
References
Details
(Keywords: meta)
Attachments
(1 file)
|
(deleted),
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
Bug 1286798 is going to add a pref to control if we use our new LS implementation:
dom.storage.next_gen
The new implementation will be disabled by default on all branches for now, but once we get positive testing results from QA, we can flip the pref on Nightly.
We target 66 currently.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 1•6 years ago
|
||
Here are latest performance testing results:
Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c82306f77dbbebfb0fc6530a008ce95076924594
Talos comparison (all talos tests):
https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=c82306f77dbbebfb0fc6530a008ce95076924594&framework=1&selectedTimeRange=172800
Raptor comparison (only tp6-1, tp6-2, tp6-3, tp6-4, tp6-5, tp6-6):
https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=c82306f77dbbebfb0fc6530a008ce95076924594&framework=10&selectedTimeRange=172800
It seems there are no performance regressions with LSNG enabled.
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Updated•6 years ago
|
Keywords: meta
Summary: Enable LSNG pref on Nightly → [meta] Enable LSNG pref on Nightly
|
|
Assignee | |
Comment 2•6 years ago
|
||
There are patches for all bugs that block enabling LSNG on Nightly.
However I'm still working on a test for bug 1513892, but other than that, things look good.
|
|
Assignee | |
Comment 3•6 years ago
|
||
Once bug 1513892 is fixed, we can flip the pref.
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9032807 [details] [diff] [review]
patch
Review of attachment 9032807 [details] [diff] [review]:
-----------------------------------------------------------------
Wooooooo!
Attachment #9032807 -
Flags: review?(bugmail) → review+
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
|
Assignee | |
Comment 6•6 years ago
|
||
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
||
Comment 8•6 years ago
|
||
This seems to be causing browser-wide freezing for me after a few minutes, especially when accessing Google; see bug 1516136. Maybe bug 1513859 did not resolve all sources of hanging?
|
||
Comment 9•6 years ago
|
||
I'm encountering crashes during triage that might be related to this change, first of all bug 1516231 which is a pretty tall spike. Then other stuff like this report:
https://crash-stats.mozilla.com/report/index/14107b32-76a8-409f-9ca6-834980181223
|
|
||
Comment 10•6 years ago
|
||
These new Fennec crashes also seem storage-related:
https://crash-stats.mozilla.com/report/index/c59a0dfd-6ba4-4c63-bdb6-860c20181223
https://crash-stats.mozilla.com/report/index/7794b92c-f209-404a-8965-3dcbd0181223
|
||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•