Closed
Bug 1510513
Opened 6 years ago
Closed 6 years ago
Retain the formatting of MOZ_DEFINE_ENUM_* macros
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox-esr60 fixed, firefox65 fixed)
RESOLVED
FIXED
mozilla65
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
patch
|
lizzard
:
approval-mozilla-esr60+
|
Details | Diff | Splinter Review |
These macros tend to be handled quite poorly since the clang-format
tokenizer cannot figure out how to handle them.
|
Assignee | |
Updated•6 years ago
|
Blocks: clang-format
|
|
Assignee | |
Comment 1•6 years ago
|
||
These macros tend to be handled quite poorly since the clang-format
tokenizer cannot figure out how to handle them.
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/628d20bae43f
Retain the formatting of MOZ_DEFINE_ENUM_* macros r=sylvestre
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
|
|
Assignee | |
Comment 4•6 years ago
|
||
[ESR Uplift Approval Request]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.
User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.
Fix Landed on Version: 65
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): This is a comment only change.
String or UUID changes made by this patch: None
Attachment #9031018 -
Flags: approval-mozilla-esr60?
status-firefox-esr60:
--- → affected
Comment on attachment 9031018 [details] [diff] [review]
ESR patch
OK for uplift to ESR60 as part of the clang-format project.
Attachment #9031018 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
|
|
Assignee | |
Comment 6•6 years ago
|
||
| bugherder uplift | ||
|
||
Updated•6 years ago
|
Target Milestone: Firefox 65 → mozilla65
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•