:Gijs (he/him) Reporter
	Description • 6 years ago

This is a follow-up for bug 1506173 to add a link to the "quit and close" dialog for users without automatic session restore, to enable such users to quickly enable automatic session restore. This is a follow-up because:

- we want to implement it behind a feature-pref so we can compare if having that text helps people use Firefox more / has positive effects on retention.
- it's not strictly necessary to fix the regression in bug 1506173
- it's more complex to implement because it requires a different (custom) dialog type, rather than a "standard" dialog from the prompt service

	:Gijs (he/him) Reporter
	Comment 1 • 6 years ago

Link to spec: https://mozilla.invisionapp.com/share/Y8PAV5TNSW7

	Ben Bucksch (:BenB)
	Comment 2 • 6 years ago

I think it would be better not to implement this link "Turn on session restore in preferences".

See bug 530594, bug 650298 etc.
"Session restore" leads to an "eternal session", you stay logged in even after you quit the browser, and it's not at all obvious to users.

The user might have deliberately chosen to turn it off, because it has severe privacy implications: Google and co can track me essentially forever (unless I explicitly delete cookies). So, we should not recommend this setting - it's simply a user choice. A user who has made this choice would then constantly see our recommendation to turn on session cookies. This is not the message we should give.

This appears on every quit. If I have explicitly chosen to not have this on, for privacy reasons, and Firefox asks me every time I quit the browser to enable the preference, as if something was broken, I think that's way too strong.

We should not asking for options that *decrease* privacy or security.

	:Gijs (he/him) Reporter
	Comment 3 • 6 years ago

(In reply to Ben Bucksch (:BenB) from comment #2)
> I think it would be better not to implement this link "Turn on session
> restore in preferences".
> 
> See bug 530594, bug 650298 etc.
> "Session restore" leads to an "eternal session", you stay logged in even
> after you quit the browser, and it's not at all obvious to users.

Cookies generally do this, not just session cookies, and not just when you enable session restore, which is what that bug is about. Unless you opt in to clearing cookies on shutdown, non-session cookies can and do track you anyway.

Is this surprising: yes.
Is there an easy solution to have session restore "work" as people expect, and still not lengthen session cookies at all: no.
Can websites have cookies that persist longer than 1 session irrespective of the session restore setting: yes.

> The user might have deliberately chosen to turn it off

It's not turned on by default, so you're mischaracterizing how this interaction works. You don't "turn it off" - you have to *explicitly* turn it on, and most people don't. This link is an opportunity to give people a contextual recommendation that this is something they might want.

> , because it has
> severe privacy implications: Google and co can track me essentially forever
> (unless I explicitly delete cookies).

As noted above, they can do that without the session cookie issue. Disabling session restore on its own doesn't improve privacy, you'd need to also delete all the other cookies all of the time, which is something very few people do because the usability implications aren't very nice.

> So, we should not recommend this
> setting - it's simply a user choice. A user who has made this choice would
> then constantly see our recommendation to turn on session cookies. This is
> not the message we should give.

We suspect that in practice people don't find that option and/or don't connect it with the problem of "all my stuff goes away when I close the browser". Whether the one sentence linking to the option constitutes a "recommendation" is a separate question - but in context, I think it's pretty clear that this is saying "you're about to throw stuff away, you can tell Firefox not to throw stuff away [here] if you like".

> This appears on every quit. If I have explicitly chosen to not have this on,
> for privacy reasons,

As said, this is the default, and there is no way for Firefox to distinguish this choice from the user not having made a choice at all and/or not being aware the choice exists.

> We should not asking for options that *decrease* privacy or security.

There's no factual basis for this statement. This option is completely orthogonal to security - without automatic session restore enabled the exact same data is still stored on disk (for the user to retrieve manually with "restore previous session") and a malicious actor could still retrieve it, with the same access assumptions. In terms of privacy, the only issue you've highlighted is with session cookies, and as I already said, other cookies have the same privacy implications.


> and Firefox asks me every time I quit the browser to
> enable the preference, as if something was broken, I think that's way too
> strong.

Continuously showing a link that you have no use for does at some (minute) cognitive overhead, so we could potentially do something like no longer showing the link after showing it 5 or 10 times or whatever. Amy, thoughts?

	Ben Bucksch (:BenB)
	Comment 4 • 6 years ago

I think bug 650298 well illustrates the problem. Users expect to be logged out when they quit the browser. That is a security feature. Novice users often shut down the browser, just to be sure that everything is logged out. If they are not, this can lead to security problems.

Per definition, a "session" ends at the latest when the browser quits. By prolonging the session over browser quits, we're breaking the most basic semantic of "session cookies". If the user opts into this, fully knowing what it does, then it's OK, but we should not so actively and forcefully promote such a problematic preference, esp. for users who might not realize the implications.

	Meridel [:meridel]
	Comment 5 • 6 years ago

If we want to soften the message so it seems less like a recommendation, we could change the string to: 

Manage *Restore previous session" settings in Preferences

It's not as actionable or direct, but it makes the point.

	:Gijs (he/him) Reporter
	Comment 6 • 6 years ago

(In reply to Ben Bucksch (:BenB) from comment #4)
> I think bug 650298 well illustrates the problem. Users expect to be logged
> out when they quit the browser. That is a security feature. Novice users
> often shut down the browser, just to be sure that everything is logged out.
> If they are not, this can lead to security problems.

The same "security problems" exist without toggling this pref, as I already said. The data is still saved.

(In reply to Meridel from comment #5)
> If we want to soften the message so it seems less like a recommendation, we
> could change the string to: 
> 
> Manage *Restore previous session" settings in Preferences
> 
> It's not as actionable or direct, but it makes the point.

This works for me, but I'll let Amy make a decision.

	Ben Bucksch (:BenB)
	Comment 7 • 6 years ago

> The same "security problems" exist without toggling this pref, as I already said. The data is still saved.

That's a bug then, as it violates assumptions of both the website and most normal end users.

We shouldn't make it a feature. And certainly not prominently promote this feature here. It will simply bite users.

	Amy Lee [:amylee] UX
	Comment 8 • 6 years ago

I think from a product perspective we actually *want* to promote this feature to determine if there is an increase in engagement with users that turn Session Restore on. We can soften the message as mentioned in comment 5 to be less of a recommendation but I would like to get Peter's input on this.

	:Gijs (he/him) Reporter
	Comment 9 • 6 years ago

Unassigning for now.