Closed
Bug 1510615
Opened 6 years ago
Closed 5 years ago
Lint Warning: Hardcoded reference to /sdcard
Categories
(GeckoView :: General, enhancement, P5)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fluffyemily, Assigned: owlish)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Your code should not reference the /sdcard path directly; instead use Environment.getExternalStorageDirectory().getPath().
Similarly, do not reference the /data/data/ path directly; it can vary in multi-user scenarios. Instead, use Context.getFilesDir().getPath().
This issue currently affects:
CrashHandler.java
GeckoLoader.java
|
||
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → bugzeeeeee
|
Reporter | |
Comment 2•5 years ago
|
||
If you need help setting up GeckoView, you can follow our setup guides on our documentation site: https://mozilla.github.io/geckoview/contributor/.
Feel free to use the public Riot GeckoView channel to ask questions: https://chat.mozilla.org/#/room/#geckoview:mozilla.org
|
|
Assignee | |
Comment 3•5 years ago
|
||
(In reply to Emily Toop (:fluffyemily) from comment #2)
If you need help setting up GeckoView, you can follow our setup guides on our documentation site: https://mozilla.github.io/geckoview/contributor/.
I have already set up my environment using that doc (it's really excellent!).
Feel free to use the public Riot GeckoView channel to ask questions: https://chat.mozilla.org/#/room/#geckoview:mozilla.org
I will, thank you!
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/03fc2ea7048c
Replace hardcoded /data/data paths or supress lint warning where not replaceable r=geckoview-reviewers,snorp
|
|
Assignee | |
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•