Closed
Bug 1510644
Opened 6 years ago
Closed 6 years ago
Lint Error: Incorrect constant
Categories
(GeckoView :: General, enhancement, P5)
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: fluffyemily, Assigned: fluffyemily)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Ensures that when parameter in a method only allows a specific set of constants, calls obey those rules.
Current affected classes:
GeckoSession
WebRequestError
|
||
Updated•6 years ago
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → etoop
|
|
Assignee | |
Comment 1•6 years ago
|
||
* Suppressed warnings for `GeckoMediaDrmBridgeV21` and `WebRequestError`
* `GeckoSession` was providing the arguments to `WebRequestError` in the incorrect order.
* Enforced `actions` array to be `SelectionActionDelegate.Action` types.
Pushed by etoop@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/469284e87cf0
Address `Incorrect constant` Android lint error. r=geckoview-reviewers,esawin
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•6 years ago
|
Keywords: good-first-bug
Target Milestone: Firefox 66 → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•