Closed Bug 1510651 Opened 6 years ago Closed 1 year ago

Lint Error: Too Long Log Tags

Categories

(GeckoView :: General, enhancement, P5)

Product:
GeckoView
Component:
General
Platform:
Unspecified
Android
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: fluffyemily, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Log tags are only allowed to be at most 23 tag characters long. Affected Classes: BasicSelectionActionDelegate DynamicToolbarAnimator GeckoServiceChildProcess GeckoSystemStateListener HardwareCodecCapabilityUtils RemoteMediaDrmBridge RemoteMediaDrmBridgeStub
Keywords: good-first-bug
OS: Unspecified → Android
Priority: -- → P5
Product: Firefox for Android → GeckoView

Hi I would like to pick this up as one of my first bugs, I just wanted some follow up for this. Should I try and abbreviate the names or totally rename them (I dont want to rename them and have them lose their definitive meaning).

Any pointers on how to approach this would be appreciated, thanks.

I would say simply to truncate the LOGTAG value until it is under the 23 character limit.

In the case of RemoteMediaDrmBridge and RemoteMediaDrmBridgeStub where simple truncation would leave to identical LOGTAGs, truncate RemoteMediaDrmBridge and remove Bridge from RemoteMediaDrmBridgeStub

RemoteMediaDrmBridge -> GeckoRemoteMediaDrmBrid
RemoteMediaDrmBridgeStub -> GeckoRemoteMediaDrmStub

Severity: normal → S3

Enhancements should have severity N/A.

Severity: S3 → N/A

This appears to have been fixed in this revision from 2019. Android Studio is showing no violations in the codebase. Closing this.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.