Open
Bug 1510660
Opened 6 years ago
Updated 1 year ago
Lint Warning: Use apply() on SharedPreferences
Categories
(GeckoView :: General, enhancement, P5)
Tracking
(Not tracked)
ASSIGNED
People
(Reporter: fluffyemily, Assigned: Logan)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=java])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Consider using apply() instead of commit on shared preferences. Whereas commit blocks and writes its data to persistent storage immediately, apply will handle it in the background.
Affected Classes:
GeckoAppShell
GeckoProfile.
Initial look at these suggests that we are calling `commit` as we desire synchronous writes and so here we probably just want to suppress the warnings.
|
||
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Comment 1•6 years ago
|
||
I would like to take up this issue. Is that alright?
Flags: needinfo?(cpeterson)
|
Reporter | |
Comment 2•6 years ago
|
||
Hi EvaNanyonga, absolutely!
If you need to get up and running with GeckoView you can refer to our getting started guide here: https://mozilla.github.io/geckoview/tutorials/geckoview-quick-start.html
You can run the lint using ./mach android lint after you set up the workspace using the guide linked above.
Feel free to ask any questions here on the bug or on IRC at #mobile.
Assignee: nobody → evewish
Flags: needinfo?(cpeterson)
|
||
Comment 3•3 years ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Assignee: evewish → nobody
|
|
||
Updated•2 years ago
|
Severity: normal → S3
|
||
Updated•2 years ago
|
Whiteboard: [lang=java]
|
Assignee | |
Comment 5•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → loganrosen
Status: NEW → ASSIGNED
You need to log in
before you can comment on or make changes to this bug.
Description
•