Closed
Bug 1510678
Opened 6 years ago
Closed 6 years ago
Change recommended addons for Firefox 64 CFR release
Categories
(Firefox :: Messaging System, defect, P1)
Firefox
Messaging System
Tracking
()
People
(Reporter: tspurway, Assigned: k88hudson)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
Let's change the CFR Message Provider for CFR addons to *only* include these three addons:
- Facebook Container
- Youtube
- Google Translate
Let's land, export and uplift to 64.
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → khudson
Severity: normal → major
Iteration: --- → 65.3 (Nov 30)
status-firefox64:
--- → affected
status-firefox65:
--- → affected
tracking-firefox64:
--- → ?
Priority: -- → P1
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/d028c328291ecd5527987a9596bcd98077cf81d1
Bug 1510678 - Change recommended addons for Firefox 64 CFR release
Comment 3•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment 4•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 9028700 [details]
Bug 1510678 - Change recommended addons for Firefox 64 CFR release
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 1510678
User impact if declined: Based on product decision making from studies in 63, we remove limit the extensions we are shipping to users to 3 out of the original 5 extensions. We cannot ship without removing these extensions
Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: Yes
If yes, steps to reproduce: 1. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled pref to true to enable the devtools
2. Visit about:newtab#asrouter
3. Enable CFR via the checkbox and set message provider selector to "cfr"
4. Ensure there are only the three CFR messages as defined in the first comment of this bug.
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Small configuration change; no major code changes
String changes made/needed:
Attachment #9028700 -
Flags: approval-mozilla-beta?
Updated•6 years ago
|
Flags: qe-verify+
Comment 6•6 years ago
|
||
Comment on attachment 9028700 [details]
Bug 1510678 - Change recommended addons for Firefox 64 CFR release
CFR update for 64.0rc1
Attachment #9028700 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•6 years ago
|
||
bugherder uplift |
Comment 8•6 years ago
|
||
I have verified that this issue is no longer reproducible with the latest Firefox Beta build (64.0 Build ID - 20181203202653) and with the latest Firefox Nightly build (65.0a1 Build ID - 20181204215402) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, only the "Facebook Container", "YouTube" and "Google Translate" add-ons are displayed in the "CFR" section from the "AS Router" page.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•