Closed
Bug 1511387
Opened 6 years ago
Closed 6 years ago
UAWidget variant of datetime needs similar click handling as XBL version
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
timdream
:
review-
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
timdream
:
review+
|
Details | Diff | Splinter Review |
The patch in bug 1089326 has the following change for the XBL
- <svg xmlns="http://www.w3.org/2000/svg" width="12" height="12">
+ <svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" style="pointer-events: none;">
<path d="M 3.9,3 3,3.9 5.1,6 3,8.1 3.9,9 6,6.9 8.1,9 9,8.1 6.9,6 9,3.9 8.1,3 6,5.1 Z M 12,6 A 6,6 0 0 1 6,12 6,6 0 0 1 0,6 6,6 0 0 1 6,0 6,6 0 0 1 12,6 Z"/>
Attachment #9028954 -
Flags: review?(timdream)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9028954 [details] [diff] [review]
uawidget_datetime_click.diff
You would need to do this in datetimebox.css because inline style will be blocked by CSP.
Attachment #9028954 -
Flags: review?(timdream) → review-
|
Assignee | |
Comment 3•6 years ago
|
||
Whaat, CSP affecting to internal elements. That is a bug. But ok.
|
|
Assignee | |
Comment 4•6 years ago
|
||
Something like this then
Assignee: nobody → bugs
Attachment #9029035 -
Flags: review?(timdream)
|
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9029035 [details] [diff] [review]
uawidget_datetime_click_2.diff
I wonder if bug 1505887 actually have made CSP not applicable to UA Widget DOM already, but this should work regardless.
Attachment #9029035 -
Flags: review?(timdream) → review+
|
||
Comment 6•6 years ago
|
||
The patch landed with number of the duplicated bug.
https://hg.mozilla.org/mozilla-central/rev/eb4344bead3e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•