Closed
Bug 1511644
Opened 6 years ago
Closed 6 years ago
statusbarpanel custom elements not working in Search messages dialog
Categories
(MailNews Core :: XUL Replacements, defect)
Tracking
(thunderbird65 fixed, thunderbird66 fixed)
RESOLVED
FIXED
Thunderbird 66.0
People
(Reporter: aceman, Assigned: arshad)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jorgk-bmo
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
I found out the statusbarpanel elements from bug 1491660 are not working in SearchDialog.xul and possibly FilterListDialog.xul.
The customElements.js is not loaded here, https://searchfox.org/comm-central/source/mail/components/mailGlue.js#142 never runs.
Thus, there are no status messages shown in the dialog (e.g. how many messages were found). Only the progressmeter flashes by when search is in progress.
Component: General → XUL Replacements
Product: Thunderbird → MailNews Core
Version: Trunk → 65
Assignee | ||
Comment 1•6 years ago
|
||
It looks like the windows created by Services.wm.getMostRecentWindow, are the cases for which custom elements are not loaded.
Assignee | ||
Comment 2•6 years ago
|
||
Comment on attachment 9029939 [details] [diff] [review]
loadStatusbarpanel.patch
Review of attachment 9029939 [details] [diff] [review]:
-----------------------------------------------------------------
forgot to flag you for review..
Attachment #9029939 -
Flags: review?(acelists)
Comment 3•6 years ago
|
||
Comment on attachment 9029939 [details] [diff] [review]
loadStatusbarpanel.patch
Works for the search, but I don't think it's necessary for the filters. Do they display a status? I don't think so, see follow-up.
Attachment #9029939 -
Flags: review?(acelists) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/dfd8686bf342
Load statusbarpanel custom element in SearchDialog.xul. r=jorgk
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 66.0
Comment 5•6 years ago
|
||
Comment on attachment 9029939 [details] [diff] [review]
loadStatusbarpanel.patch
Needs backport.
Attachment #9029939 -
Flags: approval-comm-beta+
Comment 6•6 years ago
|
||
Attachment #9031295 -
Flags: review?(acelists)
Comment 7•6 years ago
|
||
Beta (TB 65):
https://hg.mozilla.org/releases/comm-beta/rev/16ba8334367e9a1fd702163b5087d9796aeda43a
status-thunderbird65:
--- → fixed
status-thunderbird66:
--- → fixed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/832d6196becb
Load statusbarpanel custom element in FilterListDialog.xul. r=aceman DONTBUILD
Comment 9•6 years ago
|
||
I got into trouble with Aceman for only landing half of the patch :-(
Reporter | ||
Comment 10•6 years ago
|
||
Comment on attachment 9031295 [details] [diff] [review]
1511644-remove-showStatusString.patch
Review of attachment 9031295 [details] [diff] [review]:
-----------------------------------------------------------------
I don't agree with removing this. It may be unused right now, but should get back to be used in bug 243241.
It is also buggy and the "value" should be "label".
Attachment #9031295 -
Flags: review?(acelists) → review-
Comment 11•6 years ago
|
||
Comment on attachment 9031295 [details] [diff] [review]
1511644-remove-showStatusString.patch
(In reply to :aceman from comment #10)
> I don't agree with removing this. It may be unused right now, but should get
> back to be used in bug 243241.
You're involved in too many old bugs :-(
> It is also buggy and the "value" should be "label".
OK, let's keep the buggy stuff around :-(
Attachment #9031295 -
Attachment is obsolete: true
Comment 12•6 years ago
|
||
(In reply to :aceman from comment #10)
> I don't agree with removing this. It may be unused right now, but should get
> back to be used in bug 243241.
Eh, that bug will have to add what's needed then. We can't wait wait around anticipating every scenario. If something is unused, it's out.
Comment 13•6 years ago
|
||
Beta (TB 65):
https://hg.mozilla.org/releases/comm-beta/rev/b9239ce6dc86d13d5cb666761ddc294da07d8c02 (second part)
You need to log in
before you can comment on or make changes to this bug.
Description
•