Closed Bug 1511644 Opened 6 years ago Closed 6 years ago

statusbarpanel custom elements not working in Search messages dialog

Categories

(MailNews Core :: XUL Replacements, defect)

Product:
MailNews Core
Component:
XUL Replacements
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird65 fixed, thunderbird66 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 66.0
Tracking Flags:
Tracking Status
thunderbird65 --- fixed
thunderbird66 --- fixed

People

(Reporter: aceman, Assigned: arshad)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

loadStatusbarpanel.patch
(deleted), patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review
I found out the statusbarpanel elements from bug 1491660 are not working in SearchDialog.xul and possibly FilterListDialog.xul. The customElements.js is not loaded here, https://searchfox.org/comm-central/source/mail/components/mailGlue.js#142 never runs. Thus, there are no status messages shown in the dialog (e.g. how many messages were found). Only the progressmeter flashes by when search is in progress.
Component: General → XUL Replacements
Product: Thunderbird → MailNews Core
Version: Trunk → 65
Attached patch loadStatusbarpanel.patch (deleted) — — Splinter Review
It looks like the windows created by Services.wm.getMostRecentWindow, are the cases for which custom elements are not loaded.
Comment on attachment 9029939 [details] [diff] [review] loadStatusbarpanel.patch Review of attachment 9029939 [details] [diff] [review]: ----------------------------------------------------------------- forgot to flag you for review..
Attachment #9029939 - Flags: review?(acelists)
Comment on attachment 9029939 [details] [diff] [review] loadStatusbarpanel.patch Works for the search, but I don't think it's necessary for the filters. Do they display a status? I don't think so, see follow-up.
Attachment #9029939 - Flags: review?(acelists) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/dfd8686bf342 Load statusbarpanel custom element in SearchDialog.xul. r=jorgk
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
Comment on attachment 9029939 [details] [diff] [review] loadStatusbarpanel.patch Needs backport.
Attachment #9029939 - Flags: approval-comm-beta+
Attached patch 1511644-remove-showStatusString.patch (obsolete) (deleted) — — Splinter Review
Attachment #9031295 - Flags: review?(acelists)
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/832d6196becb Load statusbarpanel custom element in FilterListDialog.xul. r=aceman DONTBUILD
I got into trouble with Aceman for only landing half of the patch :-(
Comment on attachment 9031295 [details] [diff] [review] 1511644-remove-showStatusString.patch Review of attachment 9031295 [details] [diff] [review]: ----------------------------------------------------------------- I don't agree with removing this. It may be unused right now, but should get back to be used in bug 243241. It is also buggy and the "value" should be "label".
Attachment #9031295 - Flags: review?(acelists) → review-
Comment on attachment 9031295 [details] [diff] [review] 1511644-remove-showStatusString.patch (In reply to :aceman from comment #10) > I don't agree with removing this. It may be unused right now, but should get > back to be used in bug 243241. You're involved in too many old bugs :-( > It is also buggy and the "value" should be "label". OK, let's keep the buggy stuff around :-(
Attachment #9031295 - Attachment is obsolete: true
(In reply to :aceman from comment #10) > I don't agree with removing this. It may be unused right now, but should get > back to be used in bug 243241. Eh, that bug will have to add what's needed then. We can't wait wait around anticipating every scenario. If something is unused, it's out.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: