:Gijs (he/him) Assignee
	Description • 6 years ago

(In reply to Amy Lee [:amylee] UX from bug 1506173 comment #33)
> (In reply to :Gijs (he/him) from comment #32)
> > 2) The language for the sessionrestore + quit case implies all windows will
> > be restored. We don't restore private windows. Should we add a variant to
> > that dialog that says "(except tabs from private windows)" (only when the
> > user has private windows open) ? (Ni for this).
> > Note: I don't think this is critical and I think landing this fix before
> > Monday's soft freeze (because l10n changes) *is*, so if I don't hear in time
> > I might land in the current form and move the private browsing issue to a
> > separate follow-up bug.
> 
> An alternative is to mention that session restore is not enabled in private
> browsing when the user opens a private window instead of having more copy in
> preferences. NI Meridel for her input.

That would also be helpful, but I'm worried that the positive assertion in the dialog ("You are about to close 2 windows with 4 tabs. These tabs will be restored when you restart. Are you sure you want to continue?") would still be confusing - the private tabs/windows are included in the count, and even if they weren't, I wouldn't expect users to do the counting and realize we don't restore private tabs.

	Meridel [:meridel]
	Comment 1 • 6 years ago

Current copy:

Quit and close tabs?

You are about to close 3 windows with 17 tabs. These tabs will be restored when you restart. Do you want to continue?


*New copy: How about either of these?*

Option A:

Quit and close tabs?

You are about to close 3 windows with 17 tabs. Tabs in non-private windows will be restored when you restart. Do you want to continue?


Option B:

You are about to close 3 windows with 17 tabs. Tabs (except those in private windows) will be restored when you restart. Do you want to continue?

	:Gijs (he/him) Assignee
	Comment 2 • 6 years ago

(In reply to Meridel from comment #1)
> *New copy: How about either of these?*
> 
> Option A:
> 
> Quit and close tabs?
> 
> You are about to close 3 windows with 17 tabs. Tabs in non-private windows
> will be restored when you restart. Do you want to continue?
> 
> 
> Option B:
> 
> You are about to close 3 windows with 17 tabs. Tabs (except those in private
> windows) will be restored when you restart. Do you want to continue?

Either of these wfm, though I'd lean to the former because it avoids the (nested subsentence). Amy, sound OK?

	Amy Lee [:amylee] UX
	Comment 3 • 6 years ago

(In reply to :Gijs (he/him) from comment #2)
> (In reply to Meridel from comment #1)
> > *New copy: How about either of these?*
> > 
> > Option A:
> > 
> > Quit and close tabs?
> > 
> > You are about to close 3 windows with 17 tabs. Tabs in non-private windows
> > will be restored when you restart. Do you want to continue?
> > 
> > 
> > Option B:
> > 
> > You are about to close 3 windows with 17 tabs. Tabs (except those in private
> > windows) will be restored when you restart. Do you want to continue?
> 
> Either of these wfm, though I'd lean to the former because it avoids the
> (nested subsentence). Amy, sound OK?

Agree, I like option A as well to avoid the ( ). Thanks!

	Pulsebot
	Comment 5 • 6 years ago

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e3d27539c265
clarify private browsing tabs for quit warning, r=flod

	Razvan Maries
	Comment 6 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/e3d27539c265