Convert <richlistitem> to Custom Element
Categories
(Toolkit :: XUL Widgets, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: bgrins, Assigned: surkov)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
|
Reporter | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
|
|
Reporter | |
Comment 2•6 years ago
|
||
|
||
Updated•6 years ago
|
|
Assignee | |
Comment 3•6 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #0)
The binding itself looks pretty easy:
https://bgrins.github.io/xbl-analysis/tree/#richlistitem.I assume the tricky part will be covering inherited bindings at the same
time. That might have to happen all at once, and there may be some
flattening there that could happen as well (like the autocomplete-profile-*
bindings).
All (currently) dependent bindings will go away when new about:addons is landed, the codebase already has MozRichlistitem, so the bug fix is rather trivial:
- add customElements.define("richlistitem", MozRichlistitem); into richlistbox.js
- remove richlistitem binding in xul.css
Brian, does anything prevent us from replacing richlistitem binding on CE now (leaving all dependent bindings untouched for sure)?
|
|
Reporter | |
Comment 4•6 years ago
|
||
(In reply to alexander :surkov (:asurkov) from comment #3)
(In reply to Brian Grinstead [:bgrins] from comment #0)
The binding itself looks pretty easy:
https://bgrins.github.io/xbl-analysis/tree/#richlistitem.I assume the tricky part will be covering inherited bindings at the same
time. That might have to happen all at once, and there may be some
flattening there that could happen as well (like the autocomplete-profile-*
bindings).All (currently) dependent bindings will go away when new about:addons is landed, the codebase already has MozRichlistitem, so the bug fix is rather trivial:
- add customElements.define("richlistitem", MozRichlistitem); into richlistbox.js
- remove richlistitem binding in xul.css
Brian, does anything prevent us from replacing richlistitem binding on CE now (leaving all dependent bindings untouched for sure)?
The problem is that then about:addons would have both a CE and XBL attached to richlistitem. I suppose we could skip that document before doing customElements.define() (perhaps based on an attribute on the root node or something so that we don't have to hardcode the URL), but we still couldn't remove the XBL implementation. Might be a good idea anyway to get that flipped and catch any issues early so when about:addons goes away we can delete it.
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
|
Assignee | |
Comment 6•6 years ago
|
||
tweak the summary, leaving bug 1505924 for inherited bindings
|
|
Assignee | |
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
Description
•