Closed Bug 1512581 Opened 6 years ago Closed 6 years ago

XUL Overlay Loader doesn't handle insertafter attribute according to the documentation

Categories

(MailNews Core :: XUL Replacements, defect)

defect
Not set
normal

Tracking

(thunderbird65 fixed, thunderbird66 fixed)

RESOLVED FIXED
Thunderbird 66.0
Tracking Status
thunderbird65 --- fixed
thunderbird66 --- fixed

People

(Reporter: nONoNonO, Assigned: darktrojan)

References

()

Details

Attachments

(1 file)

According to the documentation, the insertafter attribute should insert the new node after the first id found in the comma separated list. This was indeed the behavior I was experiencing in my add-on Mail Redirect in Thunderbird 60.* and before. In Thunderbird 65 however, the new element is inserted after the last id found in the list. There's of course a workaround, by specifying insertafter="a,b,a", but it would be best if the XUL Overlay Loader did this the same way it used to work. P.S. The same problem might apply to the insertbefore attribute, but I didn't use that in combination with a comma separated list in my add-on and I haven't tried it.
I've tested this against ESR60 and the comment in the code is just wrong.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9032388 - Flags: review?(philipp)
Comment on attachment 9032388 [details] [diff] [review] 1512581-overlay-insertorder-1.diff Review of attachment 9032388 [details] [diff] [review]: ----------------------------------------------------------------- Yep, you are right. Not sure what I was thinking there.
Attachment #9032388 - Flags: review?(philipp) → review+
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/8a7f1cf1ba4e Match original behaviour of insertbefore/insertafter attributes; r=Fallen DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
Attachment #9032388 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: