Closed
Bug 1512654
Opened 6 years ago
Closed 6 years ago
Properly display and support selecting search matches
Categories
(Firefox :: Address Bar, enhancement, P2)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 66
People
(Reporter: mak, Assigned: standard8)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Search matches don't have a url, so when the user confirms them nothing happens.
We should use the search service to build and visit a proper search url.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
As part of the work I'm doing on this, I'm also fixing up display of the search entries themselves in the view - as it makes it easier for manual testing - clarifying subject to make that clearer.
Blocks: quantumbar-view
Summary: Properly support selecting search matches → Properly display and support selecting search matches
Assignee | ||
Comment 2•6 years ago
|
||
This implements the correct display of search matches, except for the fact that the "Search with" text should not be shown by default only on hover.
The actual selection of the result should work the same as for the quantum bar, and have the same telemetry hooked up.
Depends on D16617
Reporter | ||
Updated•6 years ago
|
Blocks: quantumbar-nightly-experiment
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96880bb35099
Properly display search matches and make them functional on the new QuantumBar. r=dao
Comment 5•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•