Closed
Bug 1512884
Opened 6 years ago
Closed 6 years ago
remove broadcasters from mailnews/
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 66.0
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
(Keywords: meta)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1489447 +++
Remove broadcasters from mailnews.
Turns out to be pretty trivial.
broadcaster_attachSignature was not used for anything
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9030168 -
Flags: review?(acelists)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Forgot a final qrefresh.
Attachment #9030168 -
Attachment is obsolete: true
Attachment #9030168 -
Flags: review?(acelists)
Attachment #9030169 -
Flags: review?(acelists)
Comment on attachment 9030169 [details] [diff] [review]
bug1512884_mailnews_broadcaster.patch
Review of attachment 9030169 [details] [diff] [review]:
-----------------------------------------------------------------
::: mailnews/base/prefs/content/am-copies.js
@@ +292,5 @@
> // Check the Fcc Self item and setup associated picker state
> function setupFccItems()
> {
> + let checked = document.getElementById("identity.doFcc").checked;
> + document.querySelectorAll(".depends-on-do-fcc").forEach(e => {
Another clever way to open-code observers? :)
Attachment #9030169 -
Flags: review?(acelists) → review+
|
|
Assignee | |
Comment 4•6 years ago
|
||
Yeah, I think it's actually much clearer than using observers.
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
|
||
Comment 6•6 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
|
||
Comment 7•5 years ago
|
||
I overlooked this change between Thunderbird 60 and Thunderbird 68. Should it be added to the list of removed XUL elements?
|
|
Assignee | |
Comment 8•5 years ago
|
||
<broadcaster> still exists (only on the kill-list). Of course if an add-on was relying on an existing broadcaster, then it needs to adapt.
|
||
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•