Closed
Bug 1513349
Opened 6 years ago
Closed 6 years ago
Editing a tree cell causes other cells in the row to become invisible
Categories
(Toolkit :: Themes, defect)
Tracking
()
VERIFIED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox64 | --- | unaffected |
firefox65 | + | verified |
firefox66 | + | verified |
People
(Reporter: alice0775, Assigned: ntim)
References
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
[Tracking Requested - why for this release]: UI becomes broken
See attached screenshot
Steps To Reproduce:
1. Remember password
2. Open about:preferences#privacy
3. Click on [Saved Login] button
4. Click on [Show Password] Button
5. Double click on a user name or a password field to edit it
Actual Results:
Site name and other column becomes invisible.
Expected Results:
Should be visible(readable)
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f643580be3cb0f73a5f175fa366730ab16f6a42b&tochange=9a4db52c22c20c1d872c1eaac1bafd4b6b1cca66
Regressed by: 9a4db52c22c2 Tim Nguyen — Bug 1508142 - Remove remains of tree cell-based selection code. r=bzbarsky,bgrins
Reporter | ||
Comment 1•6 years ago
|
||
:ntim
Your patch seems to cause the regression, can you please look into this?
Flags: needinfo?(ntim.bugs)
Assignee | ||
Comment 2•6 years ago
|
||
This change [0] regressed this.
Reintroducing support for currentColumn + the active selector would be overkill IMO.
I believe these two rules can just be removed altogether, since the .tree-input overlays the edited cell anyway (hiding the text underneath).
[0]: https://hg.mozilla.org/integration/autoland/rev/9a4db52c22c2#l23.12
Flags: needinfo?(ntim.bugs)
Assignee | ||
Updated•6 years ago
|
Summary: When I am editing username and password in password manager, site name and other column becomes invisible. → Editing a tree cell causes other cells in the row to become invisible
Assignee | ||
Comment 4•6 years ago
|
||
Updated•6 years ago
|
Attachment #9030553 -
Attachment description: Bug 1513349 - Remove now erronous tree cell editing styles. r=dao → Bug 1513349 - Remove now erroneous tree cell editing styles. r=dao
Assignee | ||
Updated•6 years ago
|
Component: Password Manager → Themes
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/af677b06f934
Remove now erroneous tree cell editing styles. r=dao
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ntim.bugs
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 9030553 [details]
Bug 1513349 - Remove now erronous tree cell editing styles. r=dao
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 1508142
User impact if declined: See comment 0 and bug 1513329 comment 0
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: No
Needs manual test from QE?: Yes
If yes, steps to reproduce: See comment 0 and bug 1513329 comment 0
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): small CSS removal
String changes made/needed: no
Attachment #9030553 -
Attachment description: Bug 1513349 - Remove now erroneous tree cell editing styles. r=dao → Bug 1513349 - Remove now erronous tree cell editing styles. r=dao
Attachment #9030553 -
Flags: approval-mozilla-beta?
Comment 7•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Updated•6 years ago
|
Comment 8•6 years ago
|
||
Comment on attachment 9030553 [details]
Bug 1513349 - Remove now erronous tree cell editing styles. r=dao
[Triage Comment]
Removes some unnecessary and erroneous tree cell editing rules. Approved for 65.0b5.
Attachment #9030553 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•6 years ago
|
||
bugherder uplift |
Comment 10•6 years ago
|
||
Reproduced the issue on 65.0b4.
Verified as fixed with 65.0b5 build from taskcluster and Nightly 66.0a1 on Windows 10x64, macOS 10.14 and Ubuntu 14.04.
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•