Closed Bug 1513445 Opened 6 years ago Closed 6 years ago

Disallow http(s) resources to be loaded into system privileged documents

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla68

Tracking Flags:

Tracking

Status

firefox68

---

fixed

People

(Reporter: freddy, Assigned: freddy)

References

(Depends on 2 open bugs, Regressed 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(2 files, 3 obsolete files)

Bug 1513445 - Disallow web documents loaded with the SystemPrincipal 6 years ago Frederik Braun [:freddy] (deleted), text/x-phabricator-request		Details
Bug 1513445 - Disallow web documents loaded with the SystemPrincipal 6 years ago Frederik Braun [:freddy] (deleted), text/x-phabricator-request		Details
Bug 1513445: add tests 6 years ago Frederik Braun [:freddy] (deleted), text/x-phabricator-request		Details
Bug 1513445 - Disallow web documents loaded with the SystemPrincipal r=ckerschb 6 years ago Frederik Braun [:freddy] (deleted), text/x-phabricator-request		Details
Bug 1513445: add tests r=ckerschb 6 years ago Frederik Braun [:freddy] (deleted), text/x-phabricator-request		Details

Frederik Braun [:freddy]

Assignee

Description

•

6 years ago

We should not allow top-level documents or subdocuments loaded with the SystemPrincipal to live on the web.

Frederik Braun [:freddy]

Assignee

Updated

•

6 years ago

Blocks: 1305331

Frederik Braun [:freddy]

Assignee

Comment 1

•

6 years ago

Green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9556f6d4f279044d31b054390a81c7fbdb94ff17

Frederik Braun [:freddy]

Assignee

Comment 2

•

6 years ago

Attached file Bug 1513445 - Disallow web documents loaded with the SystemPrincipal (obsolete) (deleted) — Details

Bug 1513445 - Disallow web documents loaded with the SystemPrincipal

Frederik Braun [:freddy]

Assignee

Comment 3

•

6 years ago

New try run. Still green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d18b8148c2cd78532bbb5941bb88defee87fe53e

Frederik Braun [:freddy]

Assignee

Comment 4

•

6 years ago

Pushed to try with the "!xpc::IsInAutomation()" case commented out - otherwise the new codepath is never executed. https://treeherder.mozilla.org/#/jobs?repo=try&revision=0937c0a71b0fa9c3c8d7a712dda1887c1f4cb74b

Christoph Kerschbaumer [:ckerschb]

Comment 5

•

6 years ago

Assigning to you Freddy since you already are working on a patch...

Assignee: nobody → ckerschb

Status: NEW → ASSIGNED

Priority: -- → P2

Whiteboard: [domsecurity-active]

Christoph Kerschbaumer [:ckerschb]

Updated

•

6 years ago

Summary: Disallow web documents loaded with the SystemPrincipal → Disallow http(s) resources to be loaded into system privileged documents

Christoph Kerschbaumer [:ckerschb]

Comment 6

•

6 years ago

Sorry, I meant to assign this one to you Freddy, not to myself (see comment 5 :-) ).

Assignee: ckerschb → fbraun

Frederik Braun [:freddy]

Assignee

Comment 7

•

6 years ago

Attached file Bug 1513445 - Disallow web documents loaded with the SystemPrincipal (obsolete) (deleted) — Details

Frederik Braun [:freddy]

Assignee

Comment 8

•

6 years ago

Attached file Bug 1513445: add tests (obsolete) (deleted) — Details

Depends on D19350

Phabricator Automation

Updated

•

6 years ago

Attachment #9030631 - Attachment is obsolete: true

Frederik Braun [:freddy]

Assignee

Updated

•

6 years ago

Keywords: checkin-needed

Pulsebot

Comment 9

•

6 years ago

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/568de07e5c40
Disallow web documents loaded with the SystemPrincipal r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/499f5b4d205d
add tests r=ckerschb

Keywords: checkin-needed

Andrei Ciure[:aciure]

Comment 10

•

6 years ago

Backed out 2 changesets (bug 1513445) for causing xpc perma fails

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=238954089&revision=499f5b4d205d601f41f772e7eff3c52d3927e23e

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=eb58abd1cf11cdc20fa184b65b113df527bf5dba&selectedJob=238957852&searchStr=android%2C4.3%2Capi16%2B%2Cdebug%2Cxpcshell%2Ctests%2Ctest-android-em-4.3-arm7-api-16%2Fdebug-xpcshell-3%2Cx%28x3%29

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=eb58abd1cf11cdc20fa184b65b113df527bf5dba&selectedJob=238961516&searchStr=linux%2Cx64%2Cdebug%2Cxpcshell%2Ctests%2Ctest-linux64%2Fdebug-xpcshell-6%2Cx%28x6%29

backout: https://hg.mozilla.org/integration/autoland/rev/8fcb2ad64899854db6b7a4b27b8c7f518e95e528

Flags: needinfo?(fbraun)

Frederik Braun [:freddy]

Assignee

Comment 11

•

6 years ago

Attached file Bug 1513445 - Disallow web documents loaded with the SystemPrincipal r=ckerschb (deleted) — Details

Frederik Braun [:freddy]

Assignee

Comment 12

•

6 years ago

Attached file Bug 1513445: add tests r=ckerschb (deleted) — Details

Depends on D26680

Frederik Braun [:freddy]

Assignee

Comment 13

•

6 years ago

Ah, thanks for the backout. Turns out, that xpcshell tests do not have a profile necessarily.
New revision should be OK, checks whether non-local connections are disabled.

Flags: needinfo?(fbraun)

Frederik Braun [:freddy]

Assignee

Comment 14

•

6 years ago

Newest revision green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f40e4945deae99256b74e2ac1f12457a7c9e1d3&selectedJob=239054293

Frederik Braun [:freddy]

Assignee

Updated

•

6 years ago

Keywords: checkin-needed

Pulsebot

Comment 15

•

6 years ago

Pushed by opoprus@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18f074af5d93
Disallow web documents loaded with the SystemPrincipal r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/59c870edc677
add tests r=ckerschb

Keywords: checkin-needed

Daniel Varga [:dvarga]

Comment 16

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/18f074af5d93
https://hg.mozilla.org/mozilla-central/rev/59c870edc677

Status: ASSIGNED → RESOLVED

Closed: 6 years ago

status-firefox68: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla68

Frederik Braun [:freddy]

Assignee

Updated

•

6 years ago

Attachment #9042931 - Attachment is obsolete: true

Frederik Braun [:freddy]

Assignee

Updated

•

6 years ago

Attachment #9042932 - Attachment is obsolete: true

Jorg K (CEST = GMT+2)

Updated

•

6 years ago

Depends on: 1544204

Regressions: 1544204

Paul Theriault [:pauljt] (no longer reading bugmail)

Updated

•

6 years ago

Depends on: 1544011

Tom S [:evilpie]

Updated

•

6 years ago

Regressions: 1544008

Frederik Braun [:freddy]

Assignee

Updated

•

6 years ago

Blocks: 1552477

Frederik Braun [:freddy]

Assignee

Updated

•

5 years ago

Depends on: 1561310

Frederik Braun [:freddy]

Assignee

Updated

•

5 years ago

No longer depends on: 1561310

Frederik Braun [:freddy]

Assignee

Updated

•

5 years ago

Depends on: 1561318

Tom Ritter [:tjr] (Back 9/5)

Updated

•

5 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1564485

Tom Ritter [:tjr] (Back 9/5)

Updated

•

5 years ago

Depends on: 1543579

Tom Ritter [:tjr] (Back 9/5)

Updated

•

5 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1473549

Frederik Braun [:freddy]

Assignee

Updated

•

5 years ago

Depends on: 1573515

You need to log in before you can comment on or make changes to this bug.