Fix nsStandardURL leak debugging
Categories
(Core :: Networking, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: dragana, Assigned: dragana)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
Assignee | ||
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 4•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 5•6 years ago
|
||
Comment 7•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 9•6 years ago
|
||
So I could not fix the previous patch. The first problem with the previous patch was that it did not use StaticMutex which is needed. This could be fix but the main problem remained:
StaticMutex initialize lazy its mMutex variable, only when it used. If we do not use it, like on the socket process that does not do anything, it will be initialize in the destructor of DumpLeakedURLs, i.e. when static variables are destroyed which causes a crash (example crash is https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=222409296&repo=try&lineNumber=1772). Therefore we need to call StaticMutexAutoLock lock(gAllURLsMutex) before destructor.
Assignee | ||
Updated•6 years ago
|
Comment 10•6 years ago
|
||
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e54c8660c447
We need to use gAllURLsMutex before destructor of a static variable. r=valentin
Comment 11•6 years ago
|
||
bugherder |
Description
•