Clear metrics when telemetry is disabled
Categories
(Data Platform and Tools :: Glean: SDK, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: Dexter, Assigned: mdroettboom)
References
Details
(Whiteboard: [telemetry:mobilesdk:m8])
Attachments
(2 files)
Reporter | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
:Dexter added in a comment in the PR that maybe what we really should be doing is removing all pending metrics and pings when telemetry is disabled (see this comment).
Comment 3•6 years ago
|
||
I would propose we hang this off one specific use-case.
From what i see in comment 0, the important one that is needed for Fenix is probably:
"A Fenix user opted out of sending Telemetry."
The expectation on Desktop is, that on disabling Telemetry (code):
- That we set the client id to a known value.
- That we discard all pending pings.
- We stop all uploading of pings.
- That we reset all metrics (Desktop only resets some actually?).
- Some exceptions might apply for Glean, like not resetting say install date?
- That we send a last optout ping, which contains no client id (follow-up bug to discuss this is required here?).
- Set the client id to a new UUID (this i think is a policy requirement).
- Start freshly recording metrics again (implementation dependent: either reset one more time or stop discarding recorded values).
Comment 4•6 years ago
|
||
Chenxia, is this the right use-case / requirement for Fenix?
Do the Desktop actions as listed here apply to mobile & Fenix as well?
Comment 5•6 years ago
|
||
This would seem like a reasonable approach to me for Mobile in general:
- if a user opts out, delete all pending telemetry pings
- stop uploading
- When you say "resetting all metrics" - does that also mean we stop updating them locally (like histograms)? That also seems to make sense to me.
2 seems absolutely necessary, 1 and 3 are things that definitely make sense and that I'd certainly prefer.
Keeping the install date also makes sense.
In terms of "Fenix requirements", let's aim for consistency across all our Mobile products. Also, I don't think there are any explicit requirements, but let me check with the Metrics team to see if there are any additional side effects they'd want to call out.
So overall this seems like a good approach.
Comment 6•6 years ago
|
||
Frank, do you have any thoughts on this, from a data analysis perspective? Do you handle clients who have turned off telemetry, and then turn it back on differently, or would this cause any glaring problems?
Comment 7•6 years ago
|
||
I don't see this causing any serious issues. Some clients do switch between them, but it's rare enough that it doesn't cause analysis issues.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 8•5 years ago
|
||
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Description
•