Closed
Bug 1513699
Opened 6 years ago
Closed 6 years ago
Crash in mozilla::wr::ImageDescriptor::ImageDescriptor when opening PDFs (Linux x64 XWayland)
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox64 | --- | unaffected |
| firefox65 | --- | disabled |
| firefox66 | --- | disabled |
People
(Reporter: jan, Assigned: sotaro)
References
(Blocks 2 open bugs)
Details
(4 keywords)
Crash Data
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
(Laurentiu Nicola from comment #17)
> This still happens for me when opening PDFs with WR enabled (Linux x64 XWayland).
(Laurentiu Nicola from comment #19)
> Are you sure that's a good idea? I came here from the crash report page, since it's the same signature:
>
> https://crash-stats.mozilla.com/report/index/be4ed823-4222-4246-b40b-835db0181212#tab-details
>
> It's also happening for others:
>
> https://crash-stats.mozilla.com/signature/?product=Firefox&signature=mozilla%3A%3Awr%3A%3AImageDescriptor%3A%3AImageDescriptor&date=%3E%3D2018-12-05T22%3A52%3A48.000Z&date=%3C2018-12-12T22%3A52%3A48.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports
|
Assignee | |
Comment 1•6 years ago
|
||
I found one STR to cause the crash. It was enabling SkiaGL by pref. But SkiaGL is disabled by default by Bug 1468801.
[1] Set gfx.webrender.all;true to about:config
[2] Set gfx.canvas.azure.accelerated;true to about:config
[3] Restart Firefox.
[4] Load pdf on Firefox.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Laurentiu Nicola, did you enabled SkiaGL? Thanks!
Flags: needinfo?(grayshade)
|
Reporter | |
Comment 3•6 years ago
|
||
Confirmed STR from comment 1. Only crashes with Wayland KDE and not with Xorg KDE.
bp-65602d70-1d08-4573-ac33-1d0b90181213
|
|
Reporter | |
Comment 4•6 years ago
|
||
mozregression --repo autoland --good 2018-11-14 --bad 2018-11-15 --pref gfx.webrender.all:true gfx.canvas.azure.accelerated:true -a https://www.privacy-handbuch.de/download/privacy-handbuch.pdf
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e762fce85daa2b0399f443c4644c6e61a11b1eb3&tochange=6fc6bdea42a60b7e3fb426beb073e07a3922913c
> 6fc6bdea42a6 Mike Hommey — Bug 1501218 - Enable wayland support with --enable-default-toolkit=cairo-gtk3. r=mshal
> 1840a5cbb59f Mike Hommey — Bug 1507030 - Use the same docker image for opt and debug base-toolchain jobs. r=froydnj
> 1f1eec6abd9b Mike Hommey — Bug 1507032 - Work around bug in wayland (< 1.12) headers. r=froydnj
RUST_BACKTRACE=1 mozregression --launch 2018-12-12 -B debug --pref gfx.webrender.all:true gfx.canvas.azure.accelerated:true -a https://www.privacy-handbuch.de/download/privacy-handbuch.pdf
> 0:47.33 INFO: [GFX2-]: Using SkiaGL canvas.
> 0:47.46 INFO: Assertion failure: false, at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/webrender/WebRenderTypes.h:72
https://searchfox.org/mozilla-central/rev/3160ddc1f0ab55d230c595366662c62950e5c785/gfx/webrender_bindings/WebRenderTypes.h#72
> case gfx::SurfaceFormat::R8G8B8X8:
> // WebRender not support RGBX8. Assert here.
> MOZ_ASSERT(false);
|
|
Reporter | |
Updated•6 years ago
|
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox64:
--- → unaffected
status-firefox65:
--- → disabled
status-firefox66:
--- → disabled
status-firefox-esr60:
--- → unaffected
Keywords: regression,
reproducible
|
|
Assignee | |
Comment 5•6 years ago
|
||
It seems better just disable SkiaGL for now, since Bug 1468801 disables SkiaGL and there is no plan to re-enable it.
|
|
Assignee | |
Comment 6•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
||
Comment 7•6 years ago
|
||
Disabling gfx.canvas.azure.accelerated fixes the crash for me.
Flags: needinfo?(grayshade)
|
|
Assignee | |
Comment 8•6 years ago
|
||
Thanks for the quick response :)
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e79c7b512fd6
Disable SkiaGL on WebRender r=jrmuizel
|
||
Comment 10•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•