Closed Bug 1513882 Opened 6 years ago Closed 6 years ago

about:welcome ReturnToAMO install button does not show the puzzle piece in the awesome bar

Categories

(Firefox :: Messaging System, defect, P2)

Product:
Firefox
Component:
Messaging System
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 66
Iteration:
66.3 - Jan 7 - 20
Tracking Flags:
Tracking Status
firefox65 --- disabled
firefox66 --- verified

People

(Reporter: andreio, Assigned: pdahiya)

References

Details

(Keywords: github-merged)

User Story

STR:
In Firefox 66, `browser.newtabpage.activity-stream.asrouter.devtoolsEnabled` set to true.
1. Navigate to `about:newtab#asrouter`
2. Scroll to the bottom and click the `Force Attribution` button
3. Naviate to `about:welcome`. You should the the RTAMO message with information about installing an addon.
4. Proceed with the installation and the step in the screenshot will appear.

Attachments

(2 files)

Screen Shot 2018-12-13 at 14.20.25.png
(deleted), image/png
Details
verified.png
(deleted), image/png
Details
Attached image Screen Shot 2018-12-13 at 14.20.25.png (deleted) —
The addons logo should show up next to the magnifing glass.
Iteration: --- → 66.2 - Dec 24 - Jan 6
status-firefox65: --- → fix-optional
status-firefox66: --- → affected
Keywords: uiwanted
Priority: -- → P2
Summary: about:welcome RTMO install button does not show the puzzle piece in the awesome bar → about:welcome ReturnToAMO install button does not show the puzzle piece in the awesome bar
This isn't ideal and should be fixed at some point, but I think we have a number of strange behaviors with doorhanger positions on new tab and probably needs a comprehensive fix. That being said, I don't really see this as blocking.
Keywords: uiwanted
Hi Andrei, Can you please add steps to replicate this issue. Thanks!
Flags: needinfo?(andrei.br92)
Assignee: nobody → pdahiya
User Story: (updated)
Flags: needinfo?(andrei.br92)
On debugging, issue seems to be pageproxystate is invalid for urlbar element on about:welcome page and we hide notification-popup-box box containing addons-notification icon by default for invalid states https://searchfox.org/mozilla-central/source/browser/base/content/browser.css#754 One option to fix is explicitly unhiding notification-popup-box before sending AddonManager.getInstallForUrl call from about:welcome page https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/ASRouter.jsm#226 Other option is to update pageproxystate to 'valid' for about:welcome provided location bar on welcome page doesn't have any dependent feature tied to invalid pageproxystate
https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#2789 The string "valid" indicates that the security indicators and other related user interface elments should be shown which we probably don't want for welcome page, will submit patch with fix in ASRouter.jsm to unhide addons-notification icon.
Iteration: 66.2 - Dec 24 - Jan 6 → 66.3 - Jan 7 - 20
Whiteboard: [github-merged]
Blocks: 1519303
Keywords: github-merged
Whiteboard: [github-merged]

https://hg.mozilla.org/mozilla-central/rev/226b130b6360

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Verified using Nightly 66.0a1 (20190120213632) on Windows 10 x64 bit and MacOS. The puzzle icon is shown when installing the attributed addon each time.

Status: RESOLVED → VERIFIED
status-firefox66: fixed → verified
Attached image verified.png (deleted) —
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: