Closed Bug 1513939 Opened 6 years ago Closed 6 years ago

Add an "app_id" field to the common information

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement
Points:
1

Tracking

()

RESOLVED FIXED
Tracking Status
firefox66 --- affected

People

(Reporter: Dexter, Assigned: Dexter)

References

Details

(Whiteboard: [telemetry:mobilesdk:m3])

Attachments

(3 files)

Looks like we're lacking a field to tell applications that use glean apart. Right now, we have "app_build" [1] but each application can have multiple builds. We need a unique identifier to distinguish things coming off the reference browser and, for example, Fenix. Such an ID will also be used in [2]. We could also make glean initialization fail hard (throw exceptions from Glean.initialize()) in case no `app_id` is provided. [1] - https://github.com/mozilla-mobile/android-components/blob/master/components/service/glean/docs/pings.md [2] - https://docs.google.com/document/u/1/d/1S8nDWcSj4zVKZjP1whXuOZhTDSIerZP5Ixm92u0a2uQ/edit
Assignee: nobody → alessio.placitelli
Blocks: 1491345
Points: --- → 1
Priority: -- → P1
Blocks: 1513941
Whiteboard: [telemetry:mobilesdk:m3]
Attached file GitHub Pull Request (deleted) —
Attached file GitHub Pull Request (deleted) —

In the discussion here, it was determined that the app id name must not contain any periods in order to work with the backend infrastructure. We probably should submit a PR to android-components to enforce this. I think it's reasonable to use the app store id, replacing all . with - as a default, and then validate any name that the application gives to glean explicitly.

Idle thought: Do we know whether or not we'll ever want to transform the name back? If so a different escaping scheme may be warranted to avoid something like:

org.mozilla.my-glean-app -> org-mozilla-my-glean-app -> org.mozilla.my.glean.app

(In reply to Chris H-C :chutten from comment #4)

Idle thought: Do we know whether or not we'll ever want to transform the name back? If so a different escaping scheme may be warranted to avoid something like:

org.mozilla.my-glean-app -> org-mozilla-my-glean-app -> org.mozilla.my.glean.app

I didn't hear any requirement about this, so I'm assuming no. I guess that if we care that much about id/names, we can add that as a specific field to the baseline/ping_info

Attached file PR for sanitizing app id (deleted) —

Everything was merged. Closing this.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: