This is part of bug 1513046.

Comment on attachment 9031348 [details] [diff] [review] feature_5_loginReputation.patch Review of attachment 9031348 [details] [diff] [review]: ----------------------------------------------------------------- LoginReputation is default disabled, so always initialize it seems wasteful. And I think we should also make sure that if the preference is disabled, no one can get that feature. Do you think it makes sense to do something like this? nsIUrlClassifierFeature* UrlClassifierFeatureFactory::GetFeatureLoginReputation() { return UrlClassifierFeatureLoginReputation::MaybeCreate(); } UrlClassifierFeatureLoginReputation::MaybeCreate() { if (!StaticPrefs::browser_safebrowsing_passwords_enabled()) { return nullptr; } if (!gFeatureLoginReputation) { gFeatureLoginReputation = new UrlClassifierFeatureLoginReputation(); gFeatureLoginReputation->InitializePreferences(); } return gFeatureLoginReputation; } ::: toolkit/components/reputationservice/LoginReputation.cpp @@ +126,5 @@ > + } > + > + nsTArray<RefPtr<nsIUrlClassifierFeature>> features; > + features.AppendElement(feature); > + The comment is gone?

We used to put login reputation changes in component SafeBrowsing

Wrong patch.

Comment on attachment 9031400 [details] [diff] [review] feature_5_loginReputation.patch Review of attachment 9031400 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks for updating this!

Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b87408f9197d Port Login-Reputation classification to nsIUrlClassifierFeature, r=dimi