Closed
Bug 1514212
Opened 6 years ago
Closed 6 years ago
Perma REFTEST TEST-UNEXPECTED-FAIL | file:///builds/worker/workspace/build/tests/jsreftest/tests/jsreftest.html?test=non262/lexical-environment/block-scoped-functions-annex-b-with.js | Unknown file
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| thunderbird_esr60 | --- | unaffected |
| geckoview64 | --- | unaffected |
| geckoview65 | --- | unaffected |
| firefox-esr60 | --- | unaffected |
| firefox64 | --- | unaffected |
| firefox65 | --- | unaffected |
| firefox66 | + | verified |
People
(Reporter: rmaries, Assigned: anba)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
[Tracking Requested - why for this release]:
Central as Beta simulations
Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&classifiedState=unclassified&revision=5cf5868e0522ed53bd67a143abc3c55b0a7cb746&selectedJob=217006569
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=217006569&repo=try&lineNumber=28007
This appears to be from bug 1512989, Andre please take a look.
Flags: needinfo?(andrebargull)
|
Assignee | |
Comment 1•6 years ago
|
||
Global var-declarations are apparently only configurable on Nightly (bug 1496510?).
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Flags: needinfo?(andrebargull)
Attachment #9031422 -
Flags: review?(jorendorff)
Tracking for 66 to make sure this is resolved before the 66 beta merge.
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9031422 [details] [diff] [review]
bug1514212.patch
Review of attachment 9031422 [details] [diff] [review]:
-----------------------------------------------------------------
Right.
Darn it, bz told me explicitly that this was the case, on the day I reviewed the previous patch, and it didn't occur to me what that meant for this test.
Attachment #9031422 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4700e46a32dd
Global var-declarations are only configurable on nightly. r=jorendorff
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
Backed out changeset 4700e46a32dd (Bug 1514212) for reftest failures in block-scoped-functions-annex-b-with.js CLOSED TREE
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=4700e46a32dd4f962f8a69a4da2b8a60b49bf637&selectedJob=217484479
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=217484479&repo=autoland&lineNumber=16416
Backout: https://hg.mozilla.org/integration/autoland/rev/acfa59a985f5e11726a8ac9a37dfebda4227928b
Flags: needinfo?(andrebargull)
|
|
Assignee | |
Comment 6•6 years ago
|
||
TestingFunctions aren't added to the global object when running jsreftests in the browser, instead it's necessary to manually import them via |SpecialPowers.Cu.getJSTestingFunctions()|.
Carrying r+ because trivial fixup.
Attachment #9031422 -
Attachment is obsolete: true
Flags: needinfo?(andrebargull)
Attachment #9032118 -
Flags: review+
|
|
Assignee | |
Comment 7•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f86feabdc02e263525b821c57533e733bb10a5a
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52c826ca7631
Global var-declarations are only configurable on nightly. r=jorendorff
Keywords: checkin-needed
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
||
Comment 10•6 years ago
|
||
Has been verified as fixed with this beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=e6b06a78bc5893afa5aaffeab4a9e6b5aab9b196
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•