Closed
Bug 1514729
Opened 6 years ago
Closed 6 years ago
Download Manager not showing toolbar in SeaMonkey 2.53
Categories
(SeaMonkey :: Download & File Handling, enhancement)
Tracking
(seamonkey2.49esr unaffected, seamonkey2.60 wontfix, seamonkey2.63 fixed, seamonkey2.53 fixed, seamonkey2.57esr fixed)
RESOLVED
FIXED
SeaMonkey2.63
| Tracking | Status | |
|---|---|---|
| seamonkey2.49esr | --- | unaffected |
| seamonkey2.60 | --- | wontfix |
| seamonkey2.63 | --- | fixed |
| seamonkey2.53 | --- | fixed |
| seamonkey2.57esr | --- | fixed |
People
(Reporter: frg, Assigned: frg)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
I just noticed that along the way we seem to have lost the toolbar in the Download Manager. Probably because of a change in Gecko. It does not show in 2.53 but works fine in 2.57. It probably works in 2.57 because some toolbar bindings were moved to comm-central.
|
Assignee | |
Comment 1•6 years ago
|
||
Even if working in 2.57 we should specify to use a toolbar. I didn't find the bug which caused the different behaviour in Gecko 56.
Attachment #9031848 -
Flags: review?(iann_bugzilla)
Attachment #9031848 -
Flags: approval-comm-esr60?
Comment on attachment 9031848 [details] [diff] [review]
1514729-dmtoolbar.patch
a/r=me
Attachment #9031848 -
Flags: review?(iann_bugzilla)
Attachment #9031848 -
Flags: review+
Attachment #9031848 -
Flags: approval-comm-esr60?
Attachment #9031848 -
Flags: approval-comm-esr60+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Was actually caused by bug 1514585. Services.ww.openWindow with a null argument behaves differently from an argument with params. Internally window.arguments is not set per mdn
nsIWindowWatcher but beats me why the window is created differently. Seems to be documented nowhere.
Depends on: 1514585
|
|
Assignee | |
Comment 4•6 years ago
|
||
New version providing an empty arguments string. Only with toolbar=yes the window turned out to be not resizable and before adding another option just lets restore the previous state.
Attachment #9031848 -
Attachment is obsolete: true
Attachment #9032138 -
Flags: review?(iann_bugzilla)
Attachment #9032138 -
Flags: approval-comm-esr60?
Comment on attachment 9032138 [details] [diff] [review]
1514729-dmtoolbar.patch
r/a=me
Attachment #9032138 -
Flags: review?(iann_bugzilla)
Attachment #9032138 -
Flags: review+
Attachment #9032138 -
Flags: approval-comm-esr60?
Attachment #9032138 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b794f9853ab5
Show the toolbar in the Download Manager. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•6 years ago
|
||
Target Milestone: --- → Future
|
|
Assignee | |
Updated•6 years ago
|
status-seamonkey2.63:
--- → fixed
Target Milestone: Future → SeaMonkey2.63
|
|
Assignee | |
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•