Closed
Bug 1514838
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 14567 - [css-contain] Layout containment suppress baseline
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14567 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/14567
Details from upstream follow.
Manuel Rego Casasnovas <rego@igalia.com> wrote:
> [css-contain] Layout containment suppress baseline
>
> We were not suppressing baseline in all the cases.
> This patch fixes the bug detected by Mozilla test
> contain-layout-suppress-baseline-002.html.
> At the same time it adds a new test for more elements,
> however it's not passing yet due to a different bug crbug.com/671132.
>
> BUG=909599
> TEST=external/wpt/css/css-contain/contain-layout-baseline-005.html
> TEST=external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-suppress-baseline-002.html
>
> Change-Id: Id1b984aae1f2a21f655b9c1e42a54115d0a4659c
> Reviewed-on: https://chromium-review.googlesource.com/1380033
> WPT-Export-Revision: a10b4d52fde228c56a083131aef867642c866f6e
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Comment 3•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=954429af9787b2b26742b78580d8a9e487b4cfa6
Assignee | ||
Comment 4•6 years ago
|
||
Ran 1 tests
FAIL : 1
New tests that have failures or other problems:
/css/css-contain/contain-layout-baseline-005.html: FAIL
Comment 5•6 years ago
|
||
FWIW, I plan on addressing at least part (if not all) of this test failure in bug 1508441.
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/321a70c6ebd2
[wpt PR 14567] - [css-contain] Layout containment suppress baseline, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/05f3afea910e
[wpt PR 14567] - Update wpt metadata, a=testonly
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/321a70c6ebd2
https://hg.mozilla.org/mozilla-central/rev/05f3afea910e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•