Closed Bug 1514874 Opened 6 years ago Closed 6 years ago

Create RemoteDataDecoder only on first use

Categories

(Core :: Audio/Video: Playback, defect, P2)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox65 --- fixed
firefox66 --- fixed

People

(Reporter: jya, Assigned: mjf)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Bug 1514874 - start RDD process on-demand
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details
The RemoteDataDecoder process is started at start time at about the same time as the GPU process. We should only start it when a media decoder is actually being requested by a content process.
Rank: 15
Priority: -- → P2
Attachment #9034515 - Attachment description: Bug 1514874 - on-demand RDD start progress DO NOT LAND → Bug 1514874 - start RDD process on-demand
Assignee: nobody → mfroman
Pushed by mfroman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d953c25fdef start RDD process on-demand r=jya,jld

I provided Talos comparing with this patch applied here https://bugzilla.mozilla.org/show_bug.cgi?id=1514172#c15

Backed out for windows asan mda failures on RemoteDecoderModule.cpp.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=8d953c25fdef67aac8b006988f072a1594516938&searchStr=windows%2C10%2Cx64%2Casan%2Cmochitests%2Cwith%2Ce10s%2Ctest-windows10-64-asan%2Fopt-mochitest-media-e10s%2Cm-e10s%28mda%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=221196979&repo=autoland&lineNumber=2491

Backout link: https://hg.mozilla.org/integration/autoland/rev/65326bd78f839f71f6c38d1b8a8e8b0cf10746e1

23:39:38 INFO - TEST-START | dom/media/test/test_playback.html
23:41:31 INFO - GECKO(6604) | [Parent 5952, Gecko_IOThread] WARNING: file z:/build/build/src/ipc/chromium/src/base/process_util_win.cc, line 166
23:41:31 INFO - GECKO(6604) | =================================================================
23:41:31 ERROR - GECKO(6604) | ==4408==ERROR: AddressSanitizer: access-violation on unknown address 0x000000000000 (pc 0x7ffda09758ef bp 0x00574f17d320 sp 0x00574f17d1c0 T651)
23:41:31 INFO - GECKO(6604) | ==4408==The signal is caused by a READ memory access.
23:41:31 INFO - GECKO(6604) | ==4408==Hint: address points to the zero page.
23:41:31 INFO - GECKO(6604) | ==4408==WARNING: Failed to use and restart external symbolizer!
23:41:31 INFO - GECKO(6604) | #0 0x7ffda09758ee in mozilla::RemoteDecoderModule::CreateVideoDecoder z:\build\build\src\dom\media\ipc\RemoteDecoderModule.cpp:58
23:41:31 INFO - GECKO(6604) | #1 0x7ffda0b41933 in mozilla::PDMFactory::CreateDecoderWithPDM z:\build\build\src\dom\media\platforms\PDMFactory.cpp:294
23:41:31 INFO - GECKO(6604) | #2 0x7ffda0b40efd in mozilla::PDMFactory::CreateDecoder z:\build\build\src\dom\media\platforms\PDMFactory.cpp:225
23:41:31 INFO - GECKO(6604) | #3 0x7ffda0587bd5 in mozilla::MediaFormatReader::DecoderFactory::DoCreateDecoder z:\build\build\src\dom\media\MediaFormatReader.cpp:552
23:41:31 INFO - GECKO(6604) | #4 0x7ffda058621c in mozilla::MediaFormatReader::DecoderFactory::RunStage z:\build\build\src\dom\media\MediaFormatReader.cpp:473
23:41:31 INFO - GECKO(6604) | #5 0x7ffda0652e14 in mozilla::MozPromise<RefPtr<mozilla::GlobalAllocPolicy::Token>,bool,1>::ThenValue<lambda at z:/build/build/src/dom/media/MediaFormatReader.cpp:447:18',lambda at z:/build/build/src/dom/media/MediaFormatReader.cpp:453:18'>::DoResolveOrRejectInternal z:\build\build\src\obj-firefox\dist\include\mozilla\MozPromise.h:716
23:41:31 INFO - GECKO(6604) | #6 0x7ffda062bdf5 in mozilla::MozPromise<const char ,RefPtr<mozilla::MediaMgrError>,1>::ThenValueBase::ResolveOrRejectRunnable::Run z:\build\build\src\obj-firefox\dist\include\mozilla\MozPromise.h:392
23:41:31 INFO - GECKO(6604) | #7 0x7ffd98027f8c in mozilla::AutoTaskDispatcher::TaskGroupRunnable::Run z:\build\build\src\obj-firefox\dist\include\mozilla\TaskDispatcher.h:197
23:41:31 INFO - GECKO(6604) | #8 0x7ffd9802e131 in mozilla::TaskQueue::Runner::Run z:\build\build\src\xpcom\threads\TaskQueue.cpp:199
23:41:31 INFO - GECKO(6604) | #9 0x7ffd98054cc9 in nsThreadPool::Run z:\build\build\src\xpcom\threads\nsThreadPool.cpp:241
23:41:31 INFO - GECKO(6604) | #10 0x7ffd980481b5 in nsThread::ProcessNextEvent z:\build\build\src\xpcom\threads\nsThread.cpp:1157
23:41:31 INFO - GECKO(6604) | #11 0x7ffd98050ad8 in NS_ProcessNextEvent z:\build\build\src\xpcom\threads\nsThreadUtils.cpp:468
23:41:31 INFO - GECKO(6604) | #12 0x7ffd99130061 in mozilla::ipc::MessagePumpForNonMainThreads::Run z:\build\build\src\ipc\glue\MessagePump.cpp:303
23:41:31 INFO - GECKO(6604) | #13 0x7ffd99087e8e in MessageLoop::RunHandler z:\build\build\src\ipc\chromium\src\base\message_loop.cc:308
23:41:31 INFO - GECKO(6604) | #14 0x7ffd99087c16 in MessageLoop::Run z:\build\build\src\ipc\chromium\src\base\message_loop.cc:290
23:41:31 INFO - GECKO(6604) | #15 0x7ffd98040d3d in nsThread::ThreadFunc z:\build\build\src\xpcom\threads\nsThread.cpp:450
23:41:31 INFO - GECKO(6604) | #16 0x7ffdb16f4350 in _PR_NativeRunThread z:\build\build\src\nsprpub\pr\src\threads\combined\pruthr.c:397
23:41:31 INFO - GECKO(6604) | #17 0x7ffdb16c4be4 in pr_root z:\build\build\src\nsprpub\pr\src\md\windows\w95thred.c:137
23:41:31 INFO - GECKO(6604) | #18 0x7ffddb010368 in o__strtoui64+0x58 (C:\Windows\System32\ucrtbase.dll+0x180020368)
23:41:31 INFO - GECKO(6604) | #19 0x7ffdc679e4b8 in __asan::AsanThread::ThreadStart Z:\task_1547091584\build\src\build\build-clang\build-clang\src\llvm\projects\compiler-rt\lib\asan\asan_thread.cc:262
23:41:31 INFO - GECKO(6604) | #20 0x7ffddcc12773 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180012773)
23:41:31 INFO - GECKO(6604) | #21 0x7ffdc7d6cd53 in patched_BaseThreadInitThunk z:\build\build\src\mozglue\build\WindowsDllBlocklist.cpp:723
23:41:31 INFO - GECKO(6604) | #22 0x7ffdde910d50 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50)
23:41:31 INFO - GECKO(6604) | AddressSanitizer can not provide additional info.
23:41:31 INFO - GECKO(6604) | SUMMARY: AddressSanitizer: access-violation z:\build\build\src\dom\media\ipc\RemoteDecoderModule.cpp:58 in mozilla::RemoteDecoderModule::CreateVideoDecoder
23:41:31 INFO - GECKO(6604) | Thread T651 created by T643 here:
23:41:31 INFO - GECKO(6604) | #0 0x7ffdc679f5f0 in __asan_wrap_CreateThread Z:\task_1547091584\build\src\build\build-clang\build-clang\src\llvm\projects\compiler-rt\lib\asan\asan_win.cc:146
23:41:31 INFO - GECKO(6604) | #1 0x7ffddb00fde6 in beginthreadex+0x56 (C:\Windows\System32\ucrtbase.dll+0x18001fde6)
23:41:31 INFO - GECKO(6604) | #2 0x7ffdb16c4a0d in _PR_MD_CREATE_THREAD z:\build\build\src\nsprpub\pr\src\md\windows\w95thred.c:151
23:41:31 INFO - GECKO(6604) | #3 0x7ffdb16f4fbd in _PR_NativeCreateThread z:\build\build\src\nsprpub\pr\src\threads\combined\pruthr.c:1044
23:41:31 INFO - GECKO(6604) | #4 0x7ffdb16f59f1 in _PR_CreateThread z:\build\build\src\nsprpub\pr\src\threads\combined\pruthr.c:1162
23:41:31 INFO - GECKO(6604) | #5 0x7ffdb16f651f in PR_CreateThread z:\build\build\src\nsprpub\pr\src\threads\combined\pruthr.c:1374
23:41:31 INFO - GECKO(6604) | #6 0x7ffd98043ae9 in nsThread::Init z:\build\build\src\xpcom\threads\nsThread.cpp:656
23:41:31 INFO - GECKO(6604) | #7 0x7ffd9804f6aa in nsThreadManager::NewNamedThread z:\build\build\src\xpcom\threads\nsThreadManager.cpp:432
23:41:31 INFO - GECKO(6604) | #8 0x7ffd98053c12 in NS_NewNamedThread z:\build\build\src\xpcom\threads\nsThreadUtils.cpp:127
23:41:31 INFO - GECKO(6604) | #9 0x7ffd980533be in nsThreadPool::PutEvent z:\build\build\src\xpcom\threads\nsThreadPool.cpp:110
23:41:31 INFO - GECKO(6604) | #10 0x7ffd98055f20 in nsThreadPool::Dispatch z:\build\build\src\xpcom\threads\nsThreadPool.cpp:287
23:41:31 INFO - GECKO(6604) | #11 0x7ffd980224ef in mozilla::SharedThreadPool::Dispatch z:\build\build\src\obj-firefox\dist\include\mozilla\SharedThreadPool.h:70
23:41:31 INFO - GECKO(6604) | #12 0x7ffd9802cb0e in mozilla::TaskQueue::DispatchLocked z:\build\build\src\xpcom\threads\TaskQueue.cpp:105
23:41:31 INFO - GECKO(6604) | #13 0x7ffd98062f78 in mozilla::TaskQueue::Dispatch z:\build\build\src\obj-firefox\dist\include\mozilla\TaskQueue.h:70
23:41:31 INFO - GECKO(6604) | #14 0x7ffd980018a3 in mozilla::AbstractThread::Dispatch z:\build\build\src\xpcom\threads\AbstractThread.cpp:206
23:41:31 INFO - GECKO(6604) | #15 0x7ffd9a06a52c in mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >,mozilla::MediaResult,1>::ThenValueBase::Dispatch z:\build\build\src\obj-firefox\dist\include\mozilla\MozPromise.h:448
23:41:31 INFO - GECKO(6604) | #16 0x7ffda08cb000 in mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >,mozilla::MediaResult,1>::DispatchAll z:\build\build\src\obj-firefox\dist\include\mozilla\MozPromise.h:965
23:41:31 INFO - GECKO(6604) | #17 0x7ffda08cbf45 in mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >,mozilla::MediaResult,1>::Private::Resolve<nsTArray<RefPtr<mozilla::MediaData> > > z:\build\build\src\obj-firefox\dist\include\mozilla\MozPromise.h:1047
23:41:31 INFO - GECKO(6604) | #18 0x7ffda09803fd in mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >,mozilla::MediaResult,1>::ChainTo z:\build\build\src\obj-firefox\dist\include\mozilla\MozPromise.h:930
23:41:31 INFO - GECKO(6604) | #19 0x7ffda0ba5000 in mozilla::detail::ProxyRunnable<mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >,mozilla::MediaResult,1>,RefPtr<mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >,mozilla::MediaResult,1> > (mozilla::OpusDataDecoder::)(mozilla::MediaRawData *),mozilla::OpusDataDecoder,mozilla::MediaRawData *>::Run z:\build\build\src\obj-firefox\dist\include\mozilla\MozPromise.h:1314
23:41:31 INFO - GECKO(6604) | #20 0x7ffd9802e131 in mozilla::TaskQueue::Runner::Run z:\build\build\src\xpcom\threads\TaskQueue.cpp:199
23:41:31 INFO - GECKO(6604) | #21 0x7ffd98054cc9 in nsThreadPool::Run z:\build\build\src\xpcom\threads\nsThreadPool.cpp:241
23:41:31 INFO - GECKO(6604) | #22 0x7ffd980481b5 in nsThread::ProcessNextEvent z:\build\build\src\xpcom\threads\nsThread.cpp:1157
23:41:31 INFO - GECKO(6604) | #23 0x7ffd98050ad8 in NS_ProcessNextEvent z:\build\build\src\xpcom\threads\nsThreadUtils.cpp:468
23:41:31 INFO - GECKO(6604) | #24 0x7ffd9913004e in mozilla::ipc::MessagePumpForNonMainThreads::Run z:\build\build\src\ipc\glue\MessagePump.cpp:333
23:41:31 INFO - GECKO(6604) | #25 0x7ffd99087e8e in MessageLoop::RunHandler z:\build\build\src\ipc\chromium\src\base\message_loop.cc:308
23:41:31 INFO - GECKO(6604) | #26 0x7ffd99087c16 in MessageLoop::Run z:\build\build\src\ipc\chromium\src\base\message_loop.cc:290
23:41:31 INFO - GECKO(6604) | #27 0x7ffd98040d3d in nsThread::ThreadFunc z:\build\build\src\xpcom\threads\nsThread.cpp:450
23:41:31 INFO - GECKO(6604) | #28 0x7ffdb16f4350 in _PR_NativeRunThread z:\build\build\src\nsprpub\pr\src\threads\combined\pruthr.c:397
23:41:31 INFO - GECKO(6604) | #29 0x7ffdb16c4be4 in pr_root z:\build\build\src\nsprpub\pr\src\md\windows\w95thred.c:137
23:41:31 INFO - GECKO(6604) | #30 0x7ffddb010368 in o__strtoui64+0x58 (C:\Windows\System32\ucrtbase.dll+0x180020368)
23:41:31 INFO - GECKO(6604) | #31 0x7ffdc679e4b8 in __asan::AsanThread::ThreadStart Z:\task_1547091584\build\src\build\build-clang\build-clang\src\llvm\projects\compiler-rt\lib\asan\asan_thread.cc:262
23:41:31 INFO - GECKO(6604) | #32 0x7ffddcc12773 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180012773)
23:41:31 INFO - GECKO(6604) | #33 0x7ffdc7d6cd53 in patched_BaseThreadInitThunk z:\build\build\src\mozglue\build\WindowsDllBlocklist.cpp:723
23:41:31 INFO - GECKO(6604) | #34 0x7ffdde910d50 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50)
23:41:31 INFO - GECKO(6604) | Thread T643 created by T636 here:
23:41:31 INFO - GECKO(6604) | #0 0x7ffdc679f5f0 in __asan_wrap_CreateThread Z:\task_1547091584\build\src\build\build-clang\build-clang\src\llvm\projects\compiler-rt\lib\asan\asan_win.cc:146
23:41:31 INFO - GECKO(6604) | #1 0x7ffddb00fde6 in beginthreadex+0x56 (C:\Windows\System32\ucrtbase.dll+0x18001fde6)
23:41:31 INFO - GECKO(6604) | #2 0x7ffdb16c4a0d in _PR_MD_CREATE_THREAD z:\build\build\src\nsprpub\pr\src\md\windows\w95thred.c:151
23:41:31 INFO - GECKO(6604) | #3 0x7ffdb16f4fbd in _PR_NativeCreateThread z:\build\build\src\nsprpub\pr\src\threads\combined\pruthr.c:1044
23:41:31 INFO - GECKO(6604) | #4 0x7ffdb16f59f1 in _PR_CreateThread z:\build\build\src\nsprpub\pr\src\threads\combined\pruthr.c:1162
23:41:31 INFO - GECKO(6604) | #5 0x7ffdb16f651f in PR_CreateThread z:\build\build\src\nsprpub\pr\src\threads\combined\pruthr.c:1374
23:41:31 INFO - GECKO(6604) | #6 0x7ffd98043ae9 in nsThread::Init z:\build\build\src\xpcom\threads\nsThread.cpp:656
23:41:31 INFO - GECKO(6604) | #7 0x7ffd9804f6aa in nsThreadManager::NewNamedThread z:\build\build\src\xpcom\threads\nsThreadManager.cpp:432
23:41:31 INFO - GECKO(6604) | #8 0x7ffd98053c12 in NS_NewNamedThread z:\build\build\src\xpcom\threads\nsThreadUtils.cpp:127
23:41:31 INFO - GECKO(6604) | #9 0x7ffd980533be in nsThreadPool::PutEvent z:\build\build\src\xpcom\threads\nsThreadPool.cpp:110
23:41:31 INFO - GECKO(6604) | #10 0x7ffd98055f20 in nsThreadPool::Dispatch z:\build\build\src\xpcom\threads\nsThreadPool.cpp:287
23:41:31 INFO - GECKO(6604) | #11 0x7ffd980224ef in mozilla::SharedThreadPool::Dispatch z:\build\build\src\obj-firefox\dist\include\mozilla\SharedThreadPool.h:70
23:41:31 INFO - GECKO(6604) | #12 0x7ffd9802cb0e in mozilla::TaskQueue::DispatchLocked z:\build\build\src\xpcom\threads\TaskQueue.cpp:105
23:41:31 INFO - GECKO(6604) | #13 0x7ffd98062f78 in mozilla::TaskQueue::Dispatch z:\build\build\src\obj-firefox\dist\include\mozilla\TaskQueue.h:70
23:41:31 INFO - GECKO(6604) | #14 0x7ffd980018a3 in mozilla::AbstractThread::Dispatch z:\build\build\src\xpcom\threads\AbstractThread.cpp:206
23:41:31 INFO - GECKO(6604) | #15 0x7ffda0b892d6 in mozilla::MediaChangeMonitor::Decode z:\build\build\src\dom\media\platforms\wrappers\MediaChangeMonitor.cpp:260
23:41:31 INFO - GECKO(6604) | #16 0x7ffda0b8f489 in mozilla::AllocationWrapper::Decode z:\build\build\src\dom\media\platforms\AllocationPolicy.h:77
23:41:31 INFO - GECKO(6604) | #17 0x7ffda05ba1ef in mozilla::MediaFormatReader::DecodeDemuxedSamples z:\build\build\src\dom\media\MediaFormatReader.cpp:1964
23:41:31 INFO - GECKO(6604) | #18 0x7ffda05bcb16 in mozilla::MediaFormatReader::HandleDemuxedSamples z:\build\build\src\dom\media\MediaFormatReader.cpp:2086
23:41:31 INFO - GECKO(6604) | #19 0x7ffda05b3b68 in mozilla::MediaFormatReader::Update z:\build\build\src\dom\media\MediaFormatReader.cpp:2464
23:41:31 INFO - GECKO(6604) | #20 0x7ffd98cb1895 in mozilla::detail::RunnableMethodImpl<nsIInterceptedChannel ,nsresult (nsIInterceptedChannel::)(nsresult),1,mozilla::RunnableKind::Standard,nsresult>::Run z:\build\build\src\obj-firefox\dist\include\nsThreadUtils.h:1158
23:41:31 INFO - GECKO(6604) | #21 0x7ffd98027f8c in mozilla::AutoTaskDispatcher::TaskGroupRunnable::Run z:\build\build\src\obj-firefox\dist\include\mozilla\TaskDispatcher.h:197
23:41:31 INFO - GECKO(6604) | #22 0x7ffd9802e131 in mozilla::TaskQueue::Runner::Run z:\build\build\src\xpcom\threads\TaskQueue.cpp:199
23:41:31 INFO - GECKO(6604) | #23 0x7ffd98054cc9 in nsThreadPool::Run z:\build\build\src\xpcom\threads\nsThreadPool.cpp:241
23:41:31 INFO - GECKO(6604) | #24 0x7ffd980481b5 in nsThread::ProcessNextEvent z:\build\build\src\xpcom\threads\nsThread.cpp:1157
23:41:31 INFO - GECKO(6604) | #25 0x7ffd98050ad8 in NS_ProcessNextEvent z:\build\build\src\xpcom\threads\nsThreadUtils.cpp:468
23:41:31 INFO - GECKO(6604) | #26 0x7ffd99130061 in mozilla::ipc::MessagePumpForNonMainThreads::Run z:\build\build\src\ipc\glue\MessagePump.cpp:303
23:41:31 INFO - GECKO(6604) | #27 0x7ffd99087e8e in MessageLoop::RunHandler z:\build\build\src\ipc\chromium\src\base\message_loop.cc:308
23:41:31 INFO - GECKO(6604) | #28 0x7ffd99087c16 in MessageLoop::Run z:\build\build\src\ipc\chromium\src\base\message_loop.cc:290
23:41:31 INFO - GECKO(6604) | #29 0x7ffd98040d3d in nsThread::ThreadFunc z:\build\build\src\xpcom\threads\nsThread.cpp:450
23:41:31 INFO - GECKO(6604) | #30 0x7ffdb16f4350 in _PR_NativeRunThread z:\build\build\src\nsprpub\pr\src\threads\combined\pruthr.c:397
23:41:31 INFO - GECKO(6604) | #31 0x7ffdb16c4be4 in pr_root z:\build\build\src\nsprpub\pr\src\md\windows\w95thred.c:137
23:41:31 INFO - GECKO(6604) | #32 0x7ffddb010368 in o__strtoui64+0x58 (C:\Windows\System32\ucrtbase.dll+0x180020368)
23:41:31 INFO - GECKO(6604) | #33 0x7ffdc679e4b8 in __asan::AsanThread::ThreadStart Z:\task_1547091584\build\src\build\build-clang\build-clang\src\llvm\projects\compiler-rt\lib\asan\asan_thread.cc:262
23:41:31 INFO - GECKO(6604) | #34 0x7ffddcc12773 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180012773)
23:41:31 INFO - GECKO(6604) | #35 0x7ffdc7d6cd53 in patched_BaseThreadInitThunk z:\build\build\src\mozglue\build\WindowsDllBlocklist.cpp:723
23:41:31 INFO - GECKO(6604) | #36 0x7ffdde910d50 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50)
23:41:31 INFO - GECKO(6604) | Thread T636 created by T0 here:
23:41:31 INFO - GECKO(6604) | #0 0x7ffdc679f5f0 in __asan_wrap_CreateThread Z:\task_1547091584\build\src\build\build-clang\build-clang\src\llvm\projects\compiler-rt\lib\asan\asan_win.cc:146
23:41:31 INFO - GECKO(6604) | #1 0x7ffddb00fde6 in beginthreadex+0x56 (C:\Windows\System32\ucrtbase.dll+0x18001fde6)
23:41:31 INFO - GECKO(6604) | #2 0x7ffdb16c4a0d in _PR_MD_CREATE_THREAD z:\build\build\src\nsprpub\pr\src\md\windows\w95thred.c:151
23:41:31 INFO - GECKO(6604) | #3 0x7ffdb16f4fbd in _PR_NativeCreateThread z:\build\build\src\nsprpub\pr\src\threads\combined\pruthr.c:1044
23:41:31 INFO - GECKO(6604) | #4 0x7ffdb16f59f1 in _PR_CreateThread z:\build\build\src\nsprpub\pr\src\threads\combined\pruthr.c:1162
23:41:31 INFO - GECKO(6604) | #5 0x7ffdb16f651f in PR_CreateThread z:\build\build\src\nsprpub\pr\src\threads\combined\pruthr.c:1374
23:41:31 INFO - GECKO(6604) | #6 0x7ffd98043ae9 in nsThread::Init z:\build\build\src\xpcom\threads\nsThread.cpp:656
23:41:31 INFO - GECKO(6604) | #7 0x7ffd9804f6aa in nsThreadManager::NewNamedThread z:\build\build\src\xpcom\threads\nsThreadManager.cpp:432
23:41:31 INFO - GECKO(6604) | #8 0x7ffd98053c12 in NS_NewNamedThread z:\build\build\src\xpcom\threads\nsThreadUtils.cpp:127
23:41:31 INFO - GECKO(6604) | #9 0x7ffd980533be in nsThreadPool::PutEvent z:\build\build\src\xpcom\threads\nsThreadPool.cpp:110
23:41:31 INFO - GECKO(6604) | #10 0x7ffd98055f20 in nsThreadPool::Dispatch z:\build\build\src\xpcom\threads\nsThreadPool.cpp:287
23:41:31 INFO - GECKO(6604) | #11 0x7ffd980224ef in mozilla::SharedThreadPool::Dispatch z:\build\build\src\obj-firefox\dist\include\mozilla\SharedThreadPool.h:70
23:41:31 INFO - GECKO(6604) | #12 0x7ffd9802cb0e in mozilla::TaskQueue::DispatchLocked z:\build\build\src\xpcom\threads\TaskQueue.cpp:105
23:41:31 INFO - GECKO(6604) | #13 0x7ffd98062f78 in mozilla::TaskQueue::Dispatch z:\build\build\src\obj-firefox\dist\include\mozilla\TaskQueue.h:70
23:41:31 INFO - GECKO(6604) | #14 0x7ffd98027a9b in mozilla::AutoTaskDispatcher::DispatchTaskGroup z:\build\build\src\obj-firefox\dist\include\mozilla\TaskDispatcher.h:245
23:41:31 INFO - GECKO(6604) | #15 0x7ffd98027171 in mozilla::AutoTaskDispatcher::~AutoTaskDispatcher z:\build\build\src\obj-firefox\dist\include\mozilla\TaskDispatcher.h:87
23:41:31 INFO - GECKO(6604) | #16 0x7ffd980253bd in mozilla::EventTargetWrapper::FireTailDispatcher z:\build\build\src\xpcom\threads\AbstractThread.cpp:74
23:41:31 INFO - GECKO(6604) | #17 0x7ffd980293ab in mozilla::detail::RunnableMethodImpl<nsIBlockThreadedExecutionCallback ,nsresult (nsIBlockThreadedExecutionCallback::)(),1,mozilla::RunnableKind::Standard>::Run z:\build\build\src\xpcom\threads\nsThreadUtils.h:1158
23:41:31 INFO - GECKO(6604) | #18 0x7ffd97e30360 in mozilla::CycleCollectedJSContext::ProcessStableStateQueue z:\build\build\src\xpcom\base\CycleCollectedJSContext.cpp:338
23:41:31 INFO - GECKO(6604) | #19 0x7ffd97e32cd6 in mozilla::CycleCollectedJSContext::AfterProcessTask z:\build\build\src\xpcom\base\CycleCollectedJSContext.cpp:397
23:41:31 INFO - GECKO(6604) | #20 0x7ffd99d5abd9 in XPCJSContext::AfterProcessTask z:\build\build\src\js\xpconnect\src\XPCJSContext.cpp:1254
23:41:31 INFO - GECKO(6604) | #21 0x7ffd98048d77 in nsThread::ProcessNextEvent z:\build\build\src\xpcom\threads\nsThread.cpp:1215
23:41:31 INFO - GECKO(6604) | #22 0x7ffd98050ad8 in NS_ProcessNextEvent z:\build\build\src\xpcom\threads\nsThreadUtils.cpp:468
23:41:31 INFO - GECKO(6604) | #23 0x7ffd9912edb6 in mozilla::ipc::MessagePump::Run z:\build\build\src\ipc\glue\MessagePump.cpp:110
23:41:31 INFO - GECKO(6604) | #24 0x7ffd99087e8e in MessageLoop::RunHandler z:\build\build\src\ipc\chromium\src\base\message_loop.cc:308
23:41:31 INFO - GECKO(6604) | #25 0x7ffd99087c16 in MessageLoop::Run z:\build\build\src\ipc\chromium\src\base\message_loop.cc:290
23:41:31 INFO - GECKO(6604) | #26 0x7ffda217548a in nsBaseAppShell::Run z:\build\build\src\widget\nsBaseAppShell.cpp:137
23:41:31 INFO - GECKO(6604) | #27 0x7ffda2306ce7 in nsAppShell::Run z:\build\build\src\widget\windows\nsAppShell.cpp:409
23:41:31 INFO - GECKO(6604) | #28 0x7ffda6bc177d in XRE_RunAppShell z:\build\build\src\toolkit\xre\nsEmbedFunctions.cpp:915
23:41:31 INFO - GECKO(6604) | #29 0x7ffd99087e8e in MessageLoop::RunHandler z:\build\build\src\ipc\chromium\src\base\message_loop.cc:308
23:41:31 INFO - GECKO(6604) | #30 0x7ffd99087c16 in MessageLoop::Run z:\build\build\src\ipc\chromium\src\base\message_loop.cc:290
23:41:31 INFO - GECKO(6604) | #31 0x7ffda6bc0999 in XRE_InitChildProcess z:\build\build\src\toolkit\xre\nsEmbedFunctions.cpp:753
23:41:31 INFO - GECKO(6604) | #32 0x7ff698ae2038 in Ordinal0+0x2038 (Z:\task_1547162161\build\application\firefox\firefox.exe+0x140002038)
23:41:31 INFO - GECKO(6604) | #33 0x7ff698ae14a1 in Ordinal0+0x14a1 (Z:\task_1547162161\build\application\firefox\firefox.exe+0x1400014a1)
23:41:31 INFO - GECKO(6604) | #34 0x7ff698bbe91b in TargetNtUnmapViewOfSection+0x2a9eb (Z:\task_1547162161\build\application\firefox\firefox.exe+0x1400de91b)
23:41:31 INFO - GECKO(6604) | #35 0x7ffddcc12773 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180012773)
23:41:31 INFO - GECKO(6604) | #36 0x7ffdde910d50 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50)

Flags: needinfo?(mfroman)

Before this got backed out, we noticed an AWSY memory improvement:

== Change summary for alert #18676 (as of Thu, 10 Jan 2019 18:41:11 GMT) ==

Improvements:

2% Heap Unclassified windows10-64 pgo stylo 43,100,491.05 -> 42,118,020.81

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=18676

I'm trying to get an asan build on my Win VM going so I can try to reproduce the asan failure locally.

Flags: needinfo?(mfroman)
Pushed by mfroman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c28b226ee6c1 start RDD process on-demand r=jya,jld

https://hg.mozilla.org/mozilla-central/rev/c28b226ee6c1

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Comment on attachment 9034515 [details]
Bug 1514874 - start RDD process on-demand

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1514172

User impact if declined: Beta and Nightly will show a launch time regression because before this patch the RDD process launched at startup.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is a fairly contained patch and really only deals with watching AV1 videos.

String changes made/needed: n/a

Attachment #9034515 - Flags: approval-mozilla-beta?

Comment on attachment 9034515 [details]
Bug 1514874 - start RDD process on-demand

[Triage Comment]
Only launch the RDD process when it's needed. Approved for 65.0b12.

Attachment #9034515 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 1533985
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: