Closed Bug 1515026 Opened 6 years ago Closed 6 years ago

No telemetry pings are sent if the stage 1 button or the "Dismiss" button from certain snippets are clicked

Categories

(Firefox :: New Tab Page, defect, P1)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 66
Iteration:
66.2 - Dec 24 - Jan 6
Tracking Flags:
Tracking Status
firefox64 --- wontfix
firefox65 - verified
firefox66 --- verified

People

(Reporter: mcoman, Assigned: andreio)

References

Details

(Keywords: github-merged)

Attachments

(4 files)

rec of the issue.gif
(deleted), image/gif
Details
Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4648
(deleted), text/x-github-pull-request
Details
Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4663
(deleted), text/x-github-pull-request
Details
Bug 1515026 - Add telemetry pings for missing AS Snippets user actions
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details
Attached image rec of the issue.gif (deleted) —
[Affected versions]: - Firefox 65.0b4 and above [Affected Platforms]: - All Windows - All Linux - All Mac [Prerequisites]: - Have the latest Firefox Nightly build installed. - Have the "Browser Console" opened. - Have a Firefox profile with the following prefs in the "about:config" page: - "browser.newtabpage.activity-stream.asrouterExperimentEnabled" with "true" value; - "browser.ping-centre.log" set to "true". [Steps to reproduce]: 1. Open the browser with the profile from prerequisites. 2. Navigate to "about:config#asrouter" page. 3. Scroll down to the "NEWSLETTER_TEST_1" section and click the "Show" button. 4. Focus the "Browser Console" and clear all the output from it. 5. Go back to the "AS Router" page and click the snippet's "Continue" button. 6. Focus the "Browser Console" and observe the displayed pings. [Expected result]: - A specific ping is displayed in the "Browser Console". [Actual result]: - No pings are displayed. [Additional Notes]: - This issue is also reproducible with the "FXA_SNIPPET_TEST_1" and the "SNIPPETS_SEND_TO_DEVICE_TEST" snippets. - According to the "QA plan for ASR Snippets" doc (https://goo.gl/KCLbkM), a specific ping should be displayed in the "Browser Console". - Attached a screen recording of the issue.
Assignee: nobody → andrei.br92
Iteration: --- → 66.2 - Dec 24 - Jan 6
Priority: -- → P1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Per discussion with tspurway, the severity of this bug doesn't warrant tracking for the 65 release, but I'll consider an uplift request still if the patch is low-risk.
tracking-firefox65: ? → -
Blocks: 1517867

I have verified this issue and it seems that is partially fixed. The pings are correctly sent for the "Dismiss" button, but there are still no pings sent for the stage 1 button.

Considering the above I am reopening the issue.

Tested with the latest Firefox Nightly (66.0a1 Build ID - 20190108215840) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3.

Status: RESOLVED → REOPENED
status-firefox66: fixed → affected
Resolution: FIXED → ---
Blocks: 1519303
Keywords: github-merged
Whiteboard: [github merged]

https://hg.mozilla.org/mozilla-central/rev/226b130b6360

Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox66: affected → fixed
Resolution: --- → FIXED

Is this something we should consider backporting to Beta?

Flags: needinfo?(andrei.br92)

More telemetry is always good.
Patch is up https://phabricator.services.mozilla.com/D16698
I reached out to QA to get this verified before requesting uplift.

Flags: needinfo?(andrei.br92)

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (66.0a1 Build ID - 20190116093310) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now a telemetry ping is sent after the "Stage 1" button is clicked.

Status: RESOLVED → VERIFIED
status-firefox66: fixed → verified

Comment on attachment 9036914 [details]
Bug 1515026 - Add telemetry pings for missing AS Snippets user actions

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1513279

User impact if declined: Missing user telemetry data for Snippets user actions

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: Already verified

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Small patch already verified by QA

String changes made/needed:

Attachment #9036914 - Flags: approval-mozilla-beta?

We should still verify this on Beta.

Flags: qe-verify+

Comment on attachment 9036914 [details]
Bug 1515026 - Add telemetry pings for missing AS Snippets user actions

[Triage Comment]
Adds more telemetry probes for AS Snippets, which are going out enabled by default in Fx65. Approved for 65.0b12.

Attachment #9036914 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified that this issue is no longer reproducible with the latest Firefox Beta (65.0b12 Build ID - 20190117232427) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now a telemetry ping is sent if the "Stage 1" button or the "Dismiss" buttons are clicked.

status-firefox65: fixed → verified
Flags: qe-verify+
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: